From: Joe Perches <joe@perches.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages
Date: Sun, 12 Jul 2015 21:30:38 -0700 [thread overview]
Message-ID: <1436761838.2711.93.camel@perches.com> (raw)
In-Reply-To: <55A33DC1.9030505@hurleysoftware.com>
On Mon, 2015-07-13 at 00:25 -0400, Peter Hurley wrote:
> On 07/12/2015 11:47 PM, Joe Perches wrote:
> > On Sun, 2015-07-12 at 22:49 -0400, Peter Hurley wrote:
> >> Introduce tty_debug() macro to output uniform debug information for
> >> tty core debug messages (function name and tty name).
> > []
> >> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> > []
> >> @@ -768,7 +768,7 @@ static void do_tty_hangup(struct work_struct *work)
> >> void tty_hangup(struct tty_struct *tty)
> >> {
> >> #ifdef TTY_DEBUG_HANGUP
> >> - printk(KERN_DEBUG "%s hangup...\n", tty_name(tty));
> >> + tty_debug(tty, "\n");
> >
> > Why drop the "hangup..." ?
>
> tty_debug() prints the function name; in this case, tty_hangup().
maybe that #ifdef/#endif block could/should be removed
and the function tracer used to track this instead.
cheers, Joe
next prev parent reply other threads:[~2015-07-13 4:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 2:49 [PATCH 0/7] tty core debug patches Peter Hurley
2015-07-13 2:49 ` [PATCH 1/7] tty: core: Improve debug message content Peter Hurley
2015-07-13 2:49 ` [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages Peter Hurley
2015-07-13 3:47 ` Joe Perches
2015-07-13 4:25 ` Peter Hurley
2015-07-13 4:30 ` Joe Perches [this message]
2015-07-13 4:40 ` Peter Hurley
2015-07-24 1:35 ` Greg Kroah-Hartman
2015-08-05 18:33 ` Peter Hurley
2015-08-05 19:22 ` Greg Kroah-Hartman
2015-07-13 2:49 ` [PATCH 3/7] tty: Replace #ifdef TTY_DEBUG_HANGUP with tty_debug_hangup() Peter Hurley
2015-07-13 2:49 ` [PATCH 4/7] tty: Use tty_debug() for tty_ldisc_debug() Peter Hurley
2015-07-13 2:49 ` [PATCH 5/7] tty: Replace inline #ifdef TTY_DEBUG_WAIT_UNTIL_SENT Peter Hurley
2015-07-13 2:49 ` [PATCH 6/7] tty: core: Improve ldisc debug messages Peter Hurley
2015-07-13 2:49 ` [PATCH 7/7] pty: Add debug message for ptmx open Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436761838.2711.93.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).