From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby" <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cris-kernel@axis.com,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: [PATCH -next] serial: etraxfs-uart: Update gpiod API
Date: Tue, 21 Jul 2015 13:34:52 -0700 [thread overview]
Message-ID: <1437510892-30376-1-git-send-email-linux@roeck-us.net> (raw)
Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
makes the flags argument to devm_gpiod_get_optional mandatory but does not
update all users. This results in the following build error.
drivers/tty/serial/etraxfs-uart.c:933:16: error:
too few arguments to function ‘devm_gpiod_get_optional’
Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/tty/serial/etraxfs-uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c
index a57301a6fe42..e35a19b214d5 100644
--- a/drivers/tty/serial/etraxfs-uart.c
+++ b/drivers/tty/serial/etraxfs-uart.c
@@ -930,10 +930,10 @@ static int etraxfs_uart_probe(struct platform_device *pdev)
up->irq = irq_of_parse_and_map(np, 0);
up->regi_ser = of_iomap(np, 0);
- up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr");
- up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr");
- up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri");
- up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd");
+ up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr", GPIOD_ASIS);
+ up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr", GPIOD_ASIS);
+ up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri", GPIOD_ASIS);
+ up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd", GPIOD_ASIS);
up->port.dev = &pdev->dev;
cris_serial_port_init(&up->port, dev_id);
--
2.1.0
next reply other threads:[~2015-07-21 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 20:34 Guenter Roeck [this message]
2015-07-21 21:01 ` [PATCH -next] serial: etraxfs-uart: Update gpiod API Uwe Kleine-König
2015-07-21 22:17 ` Guenter Roeck
2015-07-22 7:06 ` Uwe Kleine-König
2015-07-22 14:51 ` Guenter Roeck
2015-07-22 15:31 ` Niklas Cassel
2015-07-23 22:23 ` Greg Kroah-Hartman
2015-07-24 6:33 ` Uwe Kleine-König
2015-07-27 13:16 ` Linus Walleij
2015-07-27 13:29 ` Niklas Cassel
2015-07-27 13:59 ` Uwe Kleine-König
2015-07-27 14:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437510892-30376-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=jesper.nilsson@axis.com \
--cc=jslaby@suse.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).