linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Danis <frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] Revert "serial: 8250_dma: don't bother DMA with small transfers"
Date: Wed, 30 Sep 2015 14:46:31 +0200	[thread overview]
Message-ID: <1443617191-21013-1-git-send-email-frederic.danis@linux.intel.com> (raw)

This reverts commit 9119fba0cfeda6d415c9f068df66838a104b87cb.

This commit prevents from sending "big" file using Bluetooth.
When sending a lot of data quickly through the Bluetooth interface, and
after a variable amount of data sent, transfer fails with error:
    kernel: [  415.247453] Bluetooth: hci0 hardware error 0x00

Found on T100TA.

After reverting this commit, send works fine for any file size.

Signed-off-by: Frederic Danis <frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/tty/serial/8250/8250_dma.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
index 21d01a4..e508939 100644
--- a/drivers/tty/serial/8250/8250_dma.c
+++ b/drivers/tty/serial/8250/8250_dma.c
@@ -80,10 +80,6 @@ int serial8250_tx_dma(struct uart_8250_port *p)
 		return 0;
 
 	dma->tx_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
-	if (dma->tx_size < p->port.fifosize) {
-		ret = -EINVAL;
-		goto err;
-	}
 
 	desc = dmaengine_prep_slave_single(dma->txchan,
 					   dma->tx_addr + xmit->tail,
-- 
1.9.1

             reply	other threads:[~2015-09-30 12:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 12:46 Frederic Danis [this message]
     [not found] ` <1443617191-21013-1-git-send-email-frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-30 13:52   ` [PATCH] Revert "serial: 8250_dma: don't bother DMA with small transfers" Peter Hurley
     [not found]     ` <560BE919.9020803-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-09-30 14:12       ` Andy Shevchenko
     [not found]         ` <1443622344.8361.304.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-30 20:11           ` Peter Hurley
     [not found]             ` <560C420B.4030007-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-10-01  8:55               ` Andy Shevchenko
     [not found]                 ` <1443689736.8361.322.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-01 10:44                   ` Marcel Holtmann
2015-10-06  9:17                   ` Frederic Danis
     [not found]                     ` <561391AC.8050905-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-06  9:34                       ` Greg KH
     [not found]                         ` <20151006093432.GA9876-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-10-06  9:48                           ` Frederic Danis
     [not found]                             ` <561398E2.4080902-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-06 10:22                               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443617191-21013-1-git-send-email-frederic.danis@linux.intel.com \
    --to=frederic.danis-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).