[PATCH 0/8] drivers/tty/: Deinline functions when it saves at least 300 bytes per function

[PATCH 0/8] drivers/tty/: Deinline functions when it saves at least 300 bytes per function

[Denys Vlasenko]

Denys Vlasenko (8):
  tty/cyclades.c: Deinline cyy_readb, save 368 bytes
  tty/cyclades.c: Deinline cyy_writeb, save 880 bytes
  tty/cyclades.c: Deinline serial_paranoia_check, save 304 bytes
  tty/isicom.c: Deinline WaitTillCardIsFree, save 1120 bytes
  tty/serial/bcm63xx_uart.c: Deinline wait_for_xmitr, save 374 bytes
  tty/serial/jsm/jsm_neo.c: Deinline neo_parse_isr, save 688 bytes
  tty/serial/serial_core.c: Deinline uart_update_mctrl, save 304 bytes
  tty/tty_ldisc.c: Deinline tty_ldisc_put, save 368 bytes

 drivers/tty/cyclades.c            | 6 +++---
 drivers/tty/isicom.c              | 2 +-
 drivers/tty/serial/bcm63xx_uart.c | 2 +-
 drivers/tty/serial/jsm/jsm_neo.c  | 2 +-
 drivers/tty/serial/serial_core.c  | 2 +-
 drivers/tty/tty_ldisc.c           | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

-- 
1.8.1.4

[PATCH 1/8] cyclades: Deinline cyy_readb, save 368 bytes

[Denys Vlasenko]

This function compiles to 32 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/cyclades.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 87f6578..cf81fbc 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -299,7 +299,7 @@ static inline void cyy_writeb(struct cyclades_port *port, u32 reg, u8 val)
 	cy_writeb(port->u.cyy.base_addr + (reg << card->bus_index), val);
 }
 
-static inline u8 cyy_readb(struct cyclades_port *port, u32 reg)
+static u8 cyy_readb(struct cyclades_port *port, u32 reg)
 {
 	struct cyclades_card *card = port->card;
 
-- 
1.8.1.4

[PATCH 2/8] cyclades: Deinline cyy_writeb, save 880 bytes

[Denys Vlasenko]

This function compiles to 35 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/cyclades.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index cf81fbc..7f9f635 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -292,7 +292,7 @@ static void cyz_rx_restart(unsigned long);
 static struct timer_list cyz_rx_full_timer[NR_PORTS];
 #endif				/* CONFIG_CYZ_INTR */
 
-static inline void cyy_writeb(struct cyclades_port *port, u32 reg, u8 val)
+static void cyy_writeb(struct cyclades_port *port, u32 reg, u8 val)
 {
 	struct cyclades_card *card = port->card;
 
-- 
1.8.1.4

[PATCH 3/8] cyclades: Deinline serial_paranoia_check, save 304 bytes

[Denys Vlasenko]

This function compiles to 52 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/cyclades.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 7f9f635..6ead43f 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -329,7 +329,7 @@ static inline bool cyz_is_loaded(struct cyclades_card *card)
 			readl(&fw_id->signature) == ZFIRM_ID;
 }
 
-static inline int serial_paranoia_check(struct cyclades_port *info,
+static int serial_paranoia_check(struct cyclades_port *info,
 		const char *name, const char *routine)
 {
 #ifdef SERIAL_PARANOIA_CHECK
-- 
1.8.1.4

[PATCH 4/8] isicom: Deinline WaitTillCardIsFree, save 1120 bytes

[Denys Vlasenko]

This function compiles to 96 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/isicom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
index 2054427..c7698fb 100644
--- a/drivers/tty/isicom.c
+++ b/drivers/tty/isicom.c
@@ -220,7 +220,7 @@ static struct isi_port  isi_ports[PORT_COUNT];
  *	it wants to talk.
  */
 
-static inline int WaitTillCardIsFree(unsigned long base)
+static int WaitTillCardIsFree(unsigned long base)
 {
 	unsigned int count = 0;
 	unsigned int a = in_atomic(); /* do we run under spinlock? */
-- 
1.8.1.4

[PATCH 5/8] serial/bcm63xx_uart: Deinline wait_for_xmitr, save 374 bytes

[Denys Vlasenko]

This function compiles to 141 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/bcm63xx_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c
index 681e0f3..b2d2b05 100644
--- a/drivers/tty/serial/bcm63xx_uart.c
+++ b/drivers/tty/serial/bcm63xx_uart.c
@@ -653,7 +653,7 @@ static struct uart_ops bcm_uart_ops = {
 
 
 #ifdef CONFIG_SERIAL_BCM63XX_CONSOLE
-static inline void wait_for_xmitr(struct uart_port *port)
+static void wait_for_xmitr(struct uart_port *port)
 {
 	unsigned int tmout;
 
-- 
1.8.1.4

[PATCH 6/8] serial/jsm: Deinline neo_parse_isr, save 688 bytes

[Denys Vlasenko]

This function compiles to 811 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/jsm/jsm_neo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/jsm/jsm_neo.c b/drivers/tty/serial/jsm/jsm_neo.c
index 932b2ac..c6fdd63 100644
--- a/drivers/tty/serial/jsm/jsm_neo.c
+++ b/drivers/tty/serial/jsm/jsm_neo.c
@@ -714,7 +714,7 @@ static void neo_clear_break(struct jsm_channel *ch)
 /*
  * Parse the ISR register.
  */
-static inline void neo_parse_isr(struct jsm_board *brd, u32 port)
+static void neo_parse_isr(struct jsm_board *brd, u32 port)
 {
 	struct jsm_channel *ch;
 	u8 isr;
-- 
1.8.1.4

[PATCH 7/8] serial_core: Deinline uart_update_mctrl, save 304 bytes

[Denys Vlasenko]

This function compiles to 92 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/serial_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 603d2cc..0eed1fc 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -110,7 +110,7 @@ static void uart_start(struct tty_struct *tty)
 	spin_unlock_irqrestore(&port->lock, flags);
 }
 
-static inline void
+static void
 uart_update_mctrl(struct uart_port *port, unsigned int set, unsigned int clear)
 {
 	unsigned long flags;
-- 
1.8.1.4

[PATCH 8/8] tty/tty_ldisc: Deinline tty_ldisc_put, save 368 bytes

[Denys Vlasenko]

This function compiles to 72 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/tty_ldisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index 71750cb..14c4ad8 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
@@ -185,7 +185,7 @@ static struct tty_ldisc *tty_ldisc_get(struct tty_struct *tty, int disc)
  *
  *	Complement of tty_ldisc_get().
  */
-static inline void tty_ldisc_put(struct tty_ldisc *ld)
+static void tty_ldisc_put(struct tty_ldisc *ld)
 {
 	if (WARN_ON_ONCE(!ld))
 		return;
-- 
1.8.1.4

Re: [PATCH 0/8] drivers/tty/: Deinline functions when it saves at least 300 bytes per function

[Peter Hurley]

On 10/27/2015 12:39 PM, Denys Vlasenko wrote:
> Denys Vlasenko (8):
>   tty/cyclades.c: Deinline cyy_readb, save 368 bytes
>   tty/cyclades.c: Deinline cyy_writeb, save 880 bytes
>   tty/cyclades.c: Deinline serial_paranoia_check, save 304 bytes
>   tty/isicom.c: Deinline WaitTillCardIsFree, save 1120 bytes
>   tty/serial/bcm63xx_uart.c: Deinline wait_for_xmitr, save 374 bytes
>   tty/serial/jsm/jsm_neo.c: Deinline neo_parse_isr, save 688 bytes
>   tty/serial/serial_core.c: Deinline uart_update_mctrl, save 304 bytes
>   tty/tty_ldisc.c: Deinline tty_ldisc_put, save 368 bytes
> 
>  drivers/tty/cyclades.c            | 6 +++---
>  drivers/tty/isicom.c              | 2 +-
>  drivers/tty/serial/bcm63xx_uart.c | 2 +-
>  drivers/tty/serial/jsm/jsm_neo.c  | 2 +-
>  drivers/tty/serial/serial_core.c  | 2 +-
>  drivers/tty/tty_ldisc.c           | 2 +-
>  6 files changed, 8 insertions(+), 8 deletions(-)

For series,

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>