linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>
To: Sven Brauch <mail-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Peter Hurley
	<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
Subject: Re: implement put_char() in cdc-acm
Date: Wed, 28 Oct 2015 12:04:40 +0100	[thread overview]
Message-ID: <1446030280.15140.10.camel@suse.com> (raw)
In-Reply-To: <562F9C08.6050105-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>

On Tue, 2015-10-27 at 16:45 +0100, Sven Brauch wrote:
> Hey Oliver,
> 
> On 27/10/15 16:07, Oliver Neukum wrote:
> > the theory that the lack of support for put_char() is a
> > major contributor to character loss in cdc-acm can be tested.
> > Sven, could you test the attached patch? It implements
> > the support.
> Thanks a lot for caring about this. I applied the patch to a plain linux
> 4.2 tree, but unfortunately I couldn't see any improvements. Applying

That is unfortunate. So your problem is with not enough buffers.

> the patch I originally sent to the list for comparison still fixed the
> issue.

Peter, what to do about this? I think there are issues with Sven's
original patch. In particular I can't see how it can guarantee
progress. Is there a way to just really increase tty buffers,
e.g. quadruple them?

Sven, could we run a few more tests before we look at your patch
again? It really has issues, but it does help and nothing else
does. If necessary I will merge an improved version of your patch.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-10-28 11:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 15:07 implement put_char() in cdc-acm Oliver Neukum
     [not found] ` <1445958479.2043.6.camel-IBi9RG/b67k@public.gmane.org>
2015-10-27 15:45   ` Sven Brauch
     [not found]     ` <562F9C08.6050105-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
2015-10-28 11:04       ` Oliver Neukum [this message]
     [not found]         ` <1446030280.15140.10.camel-IBi9RG/b67k@public.gmane.org>
2015-10-28 12:23           ` Peter Hurley
     [not found]             ` <5630BE5E.6040204-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-10-28 12:33               ` Oliver Neukum
     [not found]                 ` <1446035622.15140.17.camel-IBi9RG/b67k@public.gmane.org>
2015-10-28 12:49                   ` Peter Hurley
2015-11-01 19:28                   ` Sven Brauch
     [not found]                     ` <563667D9.9080401-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
2015-11-01 19:59                       ` Peter Hurley
     [not found]                         ` <56366F19.90202-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-11-01 20:04                           ` Sven Brauch
2015-11-02 11:32                       ` Oliver Neukum
     [not found]                         ` <1446463972.25345.24.camel-IBi9RG/b67k@public.gmane.org>
2015-11-02 20:27                           ` Sven Brauch
     [not found]                             ` <5637C731.20409-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
2015-11-03  8:58                               ` Oliver Neukum
     [not found]                                 ` <1446541094.27681.2.camel-IBi9RG/b67k@public.gmane.org>
2015-11-03 10:13                                   ` Sven Brauch
     [not found]                                     ` <563888BB.2080601-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
2015-11-03 10:19                                       ` Oliver Neukum
2015-11-05  4:18                           ` Peter Hurley
2015-10-28 15:53               ` Sven Brauch
     [not found]                 ` <5630EF8A.8060904-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org>
2015-10-28 16:20                   ` Peter Hurley
2015-10-28 16:23                   ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446030280.15140.10.camel@suse.com \
    --to=oneukum-ibi9rg/b67k@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mail-ITmcY+a7/CDoK6nBLMlh1Q@public.gmane.org \
    --cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).