linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH v2 00/10] tty: xuartps: Fix lock ups
Date: Wed, 4 Nov 2015 23:21:09 -0800	[thread overview]
Message-ID: <1446708079-1105-1-git-send-email-soren.brinkmann@xilinx.com> (raw)

Hi,

this is v2, hopefully without any build issues. The changes are the same
as before, just the warning reported by kbuild test robot about unused
variables have been fixed. And, I added one more patch with some
cleanup/refactoring.

I recently found my system locking up under some conditions. I dug
through the code a bit and the result is this collections of various
changes. Some of it may not be required and has just been created out of
half-baked theories and re-reading the documentation. The actual failing
scenarios seem to be:
 - RX IRQ conditions are handled while the receiver is disabled, leaving
   the driver in an infinite loop
 - console_put_char seems to be interrupted by uart_shutdown disabling
   the transmitter while/just before printing

I.e. overall I tried to serialize all operations using the port lock to
avoid such interaction.

	Sören

Sören Brinkmann (10):
  tty: xuartps: Beautify read-modify writes
  tty: xuartps: Use spinlock to serialize HW access
  tty: xuartps: Always enable transmitter in start_tx
  tty: xuartps: Clear interrupt status register in shutdown
  tty: xuartps: Improve startup function
  tty: xuartps: Keep lock for whole ISR
  tty: xuartps: Acquire port lock for shutdown
  tty: xuartps: Move RX path into helper function
  tty: xuartps: Only handle RX IRQs when RX is enabled
  tty: xuartps: Cleanup: Reformat if-else

 drivers/tty/serial/xilinx_uartps.c | 247 ++++++++++++++++++++-----------------
 1 file changed, 136 insertions(+), 111 deletions(-)

-- 
2.6.2.3.ga463a5b

             reply	other threads:[~2015-11-05  7:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  7:21 Soren Brinkmann [this message]
2015-11-05  7:21 ` [PATCH v2 01/10] tty: xuartps: Beautify read-modify writes Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 02/10] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 03/10] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 04/10] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 05/10] tty: xuartps: Improve startup function Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 06/10] tty: xuartps: Keep lock for whole ISR Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 07/10] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 08/10] tty: xuartps: Move RX path into helper function Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann
2015-11-05  7:21 ` [PATCH v2 10/10] tty: xuartps: Cleanup: Reformat if-else Soren Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446708079-1105-1-git-send-email-soren.brinkmann@xilinx.com \
    --to=soren.brinkmann@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).