linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	netdev@vger.kernel.org, Johannes Stezenbach <js@sig21.net>,
	Karsten Keil <isdn@linux-pingi.de>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Mikael Starvik <starvik@axis.com>, Jiri Kosina <jikos@kernel.org>,
	David Sterba <dsterba@suse.com>,
	Mark Hounschell <markh@compro.net>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH v2 1/4] tty: rocket: Remove private close_wait
Date: Mon,  9 Nov 2015 07:15:50 -0500	[thread overview]
Message-ID: <1447071353-2961-2-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1447071353-2961-1-git-send-email-peter@hurleysoftware.com>

This driver's private completion variable, close_wait, is no longer
used for wait since "tty: Remove ASYNC_CLOSING checks in open()/hangup";
remove.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/rocket.c     | 2 --
 drivers/tty/rocket_int.h | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c
index 802eac7..c5179f8 100644
--- a/drivers/tty/rocket.c
+++ b/drivers/tty/rocket.c
@@ -643,7 +643,6 @@ static void init_r_port(int board, int aiop, int chan, struct pci_dev *pci_dev)
 	info->chan = chan;
 	tty_port_init(&info->port);
 	info->port.ops = &rocket_port_ops;
-	init_completion(&info->close_wait);
 	info->flags &= ~ROCKET_MODE_MASK;
 	switch (pc104[board][line]) {
 	case 422:
@@ -1049,7 +1048,6 @@ static void rp_close(struct tty_struct *tty, struct file *filp)
 	mutex_unlock(&port->mutex);
 	tty_port_tty_set(port, NULL);
 
-	complete_all(&info->close_wait);
 	atomic_dec(&rp_num_ports_open);
 
 #ifdef ROCKET_DEBUG_OPEN
diff --git a/drivers/tty/rocket_int.h b/drivers/tty/rocket_int.h
index 67e0f1e..ef1e1be 100644
--- a/drivers/tty/rocket_int.h
+++ b/drivers/tty/rocket_int.h
@@ -1144,7 +1144,6 @@ struct r_port {
 	int read_status_mask;
 	int cps;
 
-	struct completion close_wait;	/* Not yet matching the core */
 	spinlock_t slock;
 	struct mutex write_mtx;
 };
-- 
2.6.3

  reply	other threads:[~2015-11-09 12:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08 22:02 [PATCH 0/4] Replace tty->closing Peter Hurley
2015-11-08 22:02 ` [PATCH 1/4] tty: rocket: Remove private close_wait Peter Hurley
2015-11-08 22:02 ` [PATCH 2/4] n_tty: Ignore all read data when closing Peter Hurley
2015-11-08 22:02 ` [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley
2015-11-09  9:12   ` Johannes Stezenbach
2015-11-09 11:58     ` Peter Hurley
2015-11-08 22:02 ` [PATCH 4/4] tty: Remove drivers' extra tty_ldisc_flush() Peter Hurley
2015-11-09 12:15 ` [PATCH v2 0/4] Replace tty->closing Peter Hurley
2015-11-09 12:15   ` Peter Hurley [this message]
2015-11-09 12:15   ` [PATCH v2 2/4] n_tty: Ignore all read data when closing Peter Hurley
2015-11-09 12:15   ` [PATCH v2 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley
2015-11-09 12:15   ` [PATCH v2 4/4] tty: Remove drivers' extra tty_ldisc_flush() Peter Hurley
2015-12-14  0:16   ` [PATCH v2 0/4] Replace tty->closing Peter Hurley
2015-12-14  4:02     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447071353-2961-2-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=dsterba@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=isdn@linux-pingi.de \
    --cc=jesper.nilsson@axis.com \
    --cc=jikos@kernel.org \
    --cc=js@sig21.net \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=netdev@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).