From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stefan Agner <stefan@agner.ch>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console
Date: Mon, 16 Nov 2015 16:48:10 +0100 [thread overview]
Message-ID: <1447688894-2936779-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1447688894-2936779-1-git-send-email-arnd@arndb.de>
The newly added earlycon support for lpuart adds a
'select SERIAL_EARLYCON' statement for the tty driver, but that
only uses earlycon when console support is present, and otherwise
results in a pointless build error:
drivers/built-in.o: In function `setup_earlycon':
:(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon'
This changes the Kconfig statement to only select the earlycon
code if the console is also enabled, like all the other drivers
do already.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1d59b382f1c4 ("serial: fsl_lpuart: add earlycon support")
Cc: Stefan Agner <stefan@agner.ch>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..dbb8ac6afd40 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1539,13 +1539,13 @@ config SERIAL_FSL_LPUART
tristate "Freescale lpuart serial port support"
depends on HAS_DMA
select SERIAL_CORE
- select SERIAL_EARLYCON
help
Support for the on-chip lpuart on some Freescale SOCs.
config SERIAL_FSL_LPUART_CONSOLE
bool "Console on Freescale lpuart serial port"
depends on SERIAL_FSL_LPUART=y
+ select SERIAL_EARLYCON
select SERIAL_CORE_CONSOLE
help
If you have enabled the lpuart serial port on the Freescale SoCs,
--
2.1.0.rc2
next prev parent reply other threads:[~2015-11-16 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 15:48 [PATCH 0/6] serial: fixes and cleanups Arnd Bergmann
2015-11-16 15:48 ` [PATCH 1/6] serial: export fsl8250_handle_irq Arnd Bergmann
2015-11-16 15:48 ` Arnd Bergmann [this message]
2015-11-17 0:29 ` [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console Stefan Agner
2015-11-16 15:48 ` [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Arnd Bergmann
2015-11-16 16:56 ` Andy Shevchenko
2015-11-16 17:05 ` Arnd Bergmann
2015-11-16 15:48 ` [PATCH 4/6] serial: remove NWP serial support Arnd Bergmann
2015-11-16 15:48 ` [PATCH 5/6] serial: of: CONFIG_SERIAL_8250 is always set Arnd Bergmann
2015-11-16 15:48 ` [PATCH 6/6] serial: 8250: move of_serial code to 8250 directory Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447688894-2936779-3-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox