public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL
Date: Mon, 16 Nov 2015 16:48:11 +0100	[thread overview]
Message-ID: <1447688894-2936779-4-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1447688894-2936779-1-git-send-email-arnd@arndb.de>

The Intel MID support got split out from the PCI 8250 driver,
and that now causes a build error when no other driver selects
CONFIG_RATIONAL:

drivers/built-in.o: In function `mid8250_set_termios':
(.text+0x77418): undefined reference to `rational_best_approximation'

This adds an explicit 'select' like the combined driver had before.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d9eda9bab237 ("serial: 8250_pci: Intel MID UART support to its own driver")
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index e6f5e12a2d83..6412f1455beb 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -373,6 +373,7 @@ config SERIAL_8250_MID
 	depends on SERIAL_8250 && PCI
 	select HSU_DMA if SERIAL_8250_DMA
 	select HSU_DMA_PCI if X86_INTEL_MID
+	select RATIONAL
 	help
 	  Selecting this option will enable handling of the extra features
 	  present on the UART found on Intel Medfield SOC and various other
-- 
2.1.0.rc2

  parent reply	other threads:[~2015-11-16 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 15:48 [PATCH 0/6] serial: fixes and cleanups Arnd Bergmann
2015-11-16 15:48 ` [PATCH 1/6] serial: export fsl8250_handle_irq Arnd Bergmann
2015-11-16 15:48 ` [PATCH 2/6] serial: fsl-lpuart: move SERIAL_EARLYCON dependency to console Arnd Bergmann
2015-11-17  0:29   ` Stefan Agner
2015-11-16 15:48 ` Arnd Bergmann [this message]
2015-11-16 16:56   ` [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL Andy Shevchenko
2015-11-16 17:05     ` Arnd Bergmann
2015-11-16 15:48 ` [PATCH 4/6] serial: remove NWP serial support Arnd Bergmann
2015-11-16 15:48 ` [PATCH 5/6] serial: of: CONFIG_SERIAL_8250 is always set Arnd Bergmann
2015-11-16 15:48 ` [PATCH 6/6] serial: 8250: move of_serial code to 8250 directory Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447688894-2936779-4-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox