From: Wang Hongcheng <annie.wang@amd.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, dmaengine@vger.kernel.org,
Borislav Petkov <bp@alien8.de>, Huang Rui <ray.huang@amd.com>,
Wan Zongshun <vincent.wan@amd.com>, Ken Xue <ken.xue@amd.com>,
Robin Murphy <robin.murphy@arm.com>,
Graeme Gregory <gg@slimlogic.co.uk>, Tony Li <tony.li@amd.com>,
Xiangliang Yu <Xiangliang.Yu@amd.com>,
Wang Hongcheng <annie.wang@amd.com>
Subject: [PATCH 4/6] dmaengine: pl330: add new items for pl330 private data
Date: Mon, 4 Jan 2016 13:31:39 +0800 [thread overview]
Message-ID: <1451885501-2710-5-git-send-email-annie.wang@amd.com> (raw)
In-Reply-To: <1451885501-2710-1-git-send-email-annie.wang@amd.com>
mcbuf_sz means bytes to allocate for MicroCode buffer.
flags is for irq sharing, default is non-shared, in AMD
Carrizo, pl330 shares IRQ with its corresponding UART device.
Signed-off-by: Wang Hongcheng <annie.wang@amd.com>
---
drivers/acpi/acpi_apd.c | 17 +++++++++++++++++
drivers/dma/pl330.c | 9 ++++++++-
include/linux/amba/pl330.h | 2 ++
3 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 9520daf..4d71a65 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -20,6 +20,9 @@
#include <linux/pm.h>
#include <linux/amba/bus.h>
#include <linux/dma-mapping.h>
+#include <linux/dmaengine.h>
+#include <linux/interrupt.h>
+#include <linux/amba/pl330.h>
#include "internal.h"
@@ -33,6 +36,14 @@ struct apd_private_data;
#define ACPI_APD_SYSFS BIT(0)
#define ACPI_APD_PM BIT(1)
+static u8 peri_id[2] = { 0, 1 };
+
+static struct dma_pl330_platdata amd_pl330 = {
+ .nr_valid_peri = 2,
+ .peri_id = peri_id,
+ .mcbuf_sz = 0,
+ .flags = IRQF_SHARED,
+};
/**
* struct apd_device_desc - a descriptor for apd device
* @flags: device flags like %ACPI_APD_SYSFS, %ACPI_APD_PM
@@ -150,6 +161,12 @@ static int acpi_apd_setup_quirks(struct apd_private_data *pdata)
goto amba_register_err;
kfree(resource);
+
+ dma_cap_set(DMA_MEMCPY, amd_pl330.cap_mask);
+ dma_cap_set(DMA_SLAVE, amd_pl330.cap_mask);
+ dma_cap_set(DMA_CYCLIC, amd_pl330.cap_mask);
+ dma_cap_set(DMA_PRIVATE, amd_pl330.cap_mask);
+
return 0;
amba_register_err:
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 17ee758..5e5fb46 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -26,6 +26,8 @@
#include <linux/scatterlist.h>
#include <linux/of.h>
#include <linux/of_dma.h>
+#include <linux/acpi.h>
+#include <linux/acpi_dma.h>
#include <linux/err.h>
#include <linux/pm_runtime.h>
@@ -488,6 +490,9 @@ struct pl330_dmac {
/* Peripheral channels connected to this DMAC */
unsigned int num_peripherals;
struct dma_pl330_chan *peripherals; /* keep at end */
+
+ /*IRQ register flags */
+ unsigned int flags;
};
struct dma_pl330_desc {
@@ -2800,6 +2805,8 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
pl330->mcbufsz = pdat ? pdat->mcbuf_sz : 0;
+ pl330->flags = pdat ? pdat->flags : IRQF_TRIGGER_NONE;
+
res = &adev->res;
pl330->base = devm_ioremap_resource(&adev->dev, res);
if (IS_ERR(pl330->base))
@@ -2811,7 +2818,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
irq = adev->irq[i];
if (irq) {
ret = devm_request_irq(&adev->dev, irq,
- pl330_irq_handler, 0,
+ pl330_irq_handler, pl330->flags,
dev_name(&adev->dev), pl330);
if (ret)
return ret;
diff --git a/include/linux/amba/pl330.h b/include/linux/amba/pl330.h
index fe93758..cdc80f0 100644
--- a/include/linux/amba/pl330.h
+++ b/include/linux/amba/pl330.h
@@ -29,6 +29,8 @@ struct dma_pl330_platdata {
dma_cap_mask_t cap_mask;
/* Bytes to allocate for MC buffer */
unsigned mcbuf_sz;
+ /*flags for irq sharing, default is non-shared*/
+ unsigned flags;
};
extern bool pl330_filter(struct dma_chan *chan, void *param);
--
1.9.1
next prev parent reply other threads:[~2016-01-04 5:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 5:31 [PATCH 0/6] 8250: AMD Carrizo UART PL300 DMA enablement Wang Hongcheng
2016-01-04 5:31 ` [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Wang Hongcheng
2016-01-04 14:41 ` Borislav Petkov
2016-01-06 2:08 ` Wang, Annie
2016-01-06 10:46 ` Borislav Petkov
2016-01-11 7:26 ` Wang, Annie
2016-01-04 5:31 ` [PATCH 2/6] ACPI: create setup_quirk in acpi_apd Wang Hongcheng
2016-01-04 14:21 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 3/6] ACPI: add 2 parameters to function acpi dma controller register Wang Hongcheng
2016-01-04 14:36 ` Andy Shevchenko
2016-01-04 14:45 ` Mika Westerberg
2016-01-06 6:46 ` Wang, Annie
2016-01-07 9:52 ` Mika Westerberg
2016-01-07 10:08 ` Andy Shevchenko
2016-01-04 5:31 ` Wang Hongcheng [this message]
2016-01-04 5:43 ` [PATCH 4/6] dmaengine: pl330: add new items for pl330 private data kbuild test robot
2016-01-04 14:38 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 5/6] dmaengine: pl330: provide ACPI dmaengine interface Wang Hongcheng
2016-01-04 14:46 ` Andy Shevchenko
2016-01-04 5:31 ` [PATCH 6/6] Serial:8250: New Port Type PORT_AMD_8250 Wang Hongcheng
2016-01-04 5:47 ` kbuild test robot
2016-01-05 12:01 ` Heikki Krogerus
2016-01-14 6:23 ` Wang, Annie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451885501-2710-5-git-send-email-annie.wang@amd.com \
--to=annie.wang@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=bp@alien8.de \
--cc=dmaengine@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=ken.xue@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ray.huang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=tony.li@amd.com \
--cc=vincent.wan@amd.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).