linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Peter Hung" <hpeter@gmail.com>, "Rob Groner" <rgroner@rtd.com>,
	"One Thousand Gnomes" <gnomes@lxorguk.ukuu.org.uk>,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jslaby@suse.com>,
	"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
	"Peter Hurley" <peter@hurleysoftware.com>,
	soeren.grunewald@desy.de, "Wang YanQing" <udknight@gmail.com>,
	adam.lee@canonical.com, "Arnd Bergmann" <arnd@arndb.de>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Måns Rullgård" <mans@mansr.com>,
	scottwood@freescale.com, "Paul Burton" <paul.burton@imgtec.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Joachim Eastwood" <manabian@gmail.com>,
	"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
Date: Fri, 29 Jan 2016 20:35:14 +0200	[thread overview]
Message-ID: <1454092514.32507.3.camel@linux.intel.com> (raw)
In-Reply-To: <20160129173808.GB18826@sudip-laptop>

On Fri, 2016-01-29 at 23:08 +0530, Sudip Mukherjee wrote:
> On Fri, Jan 22, 2016 at 03:44:16PM +0200, Andy Shevchenko wrote:
> > On Fri, Jan 22, 2016 at 12:53 PM, Sudip Mukherjee
> > <sudipm.mukherjee@gmail.com> wrote:
> > > On Wed, Jan 20, 2016 at 04:24:36PM +0800, Peter Hung wrote:
> > > > Hi Sudip,
> > > > 
> > > > Sudip Mukherjee 於 2016/1/20 下午 02:22 寫道:
> > > > > On Wed, Jan 20, 2016 at 10:59:28AM +0800, Peter Hung wrote:
> > > > 
> > > > > But my personal opinion, if we move out the serial port
> > > > > related code
> > > > > into a new driver (a new Kconfig symbol) userspace of many
> > > > > system will
> > > > > break if this new symbol is not enabled by the distributions.
> > > > > But in the
> > > > > way I have done the new symbol needs to be enabled only if
> > > > > the user
> > > > > wants to use the GPIO capability. If that is not enabled GPIO
> > > > > cannot be
> > > > > used but it will never break the serial port related code for
> > > > > them.
> > > > > I think we should give a thought to that before splitting out
> > > > > the codes
> > > > > from 8250_pci.
> > > > 
> > > > I agree with your opinion. I'm trying to implement GPIO with 2
> > > > ways,
> > > > One is like yours, add platform_device with in 8250_pci.c and
> > > > implement
> > > > GPIOLIB platform driver with in 'driver/gpio", and the other is
> > > > trying
> > > > split out from 8250_pci.c to MFD.
> > > > 
> > > > In my personal opinion, the first method is less impact with
> > > > compatible
> > > > old system.
> > > 
> > > Looks like no one else is in support of our opinion. Fair enough,
> > > I will
> > > split out the related code from 8250_pci and create the MFD
> > > driver this
> > > weekend for my hardware.
> > 
> > Yeah, MFD looks preferable.
> > 
> > Btw, don't forget to backlist your devices in 8250_pci since they
> > quite possible provide a PCI class which is used by 8250_pci driver
> > for default enumeration.
> 
> One doubt. If I have understood correctly the main reason you have
> asked
> me to split the code out of 8250_pci so that the size reduces. But
> pci_xr17v35x_setup() is also used by another card which has
> PCI_VENDOR_ID_COMMTECH. So even if I create a separate file for exar
> cards,
> almost identical function will still remain in 8250_pci.

For me looks like re-branded Exar chip (Exar is a real chip vendor,
right?). Even names fall in different pattern.


Also,
        {       PCI_VENDOR_ID_COMMTECH,
PCI_DEVICE_ID_COMMTECH_4222PCIE,
                PCI_ANY_ID, PCI_ANY_ID,
                0,
                0, pbn_exar_XR17V352 },
^^^^!


Move those IDs to your driver as well.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      reply	other threads:[~2016-01-29 18:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  2:41 [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung
2016-01-19  2:41 ` [PATCH 1/3] serial: 8250_pci: Remove Fintek PCIE UART driver Peter Hung
2016-01-19  2:41 ` [PATCH 2/3] 8250_fintek_pci: Add " Peter Hung
2016-01-19  2:41 ` [PATCH 3/3] 8250_fintek_pci: Add GPIOLIB support Peter Hung
2016-01-19  3:56 ` [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Paul Gortmaker
2016-01-19  8:45   ` Peter Hung
2016-01-19  9:33     ` Andy Shevchenko
2016-01-19 12:33     ` One Thousand Gnomes
2016-01-19 13:21       ` Andy Shevchenko
2016-01-20  2:59         ` Peter Hung
2016-01-20  6:22           ` Sudip Mukherjee
2016-01-20  8:24             ` Peter Hung
2016-01-22 10:53               ` Sudip Mukherjee
2016-01-22 13:44                 ` Andy Shevchenko
2016-01-29 17:38                   ` Sudip Mukherjee
2016-01-29 18:35                     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454092514.32507.3.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=adam.lee@canonical.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hpeter@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=manabian@gmail.com \
    --cc=mans@mansr.com \
    --cc=matthias.bgg@gmail.com \
    --cc=paul.burton@imgtec.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=peter@hurleysoftware.com \
    --cc=rgroner@rtd.com \
    --cc=scottwood@freescale.com \
    --cc=soeren.grunewald@desy.de \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=udknight@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).