From: Anand Moon <linux.amoon@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Anand Moon <linux.amoon@gmail.com>
Cc: linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] serial: samsung: fix the inconsistency in spinlock
Date: Thu, 18 Feb 2016 23:10:02 +0530 [thread overview]
Message-ID: <1455817202-3005-1-git-send-email-linux.amoon@gmail.com> (raw)
From: Anand Moon <linux.amoon@gmail.com>
changes fix the correct order of the spin_lock_irqrestore/save.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/tty/serial/samsung.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index d72cd73..96fe14d 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -759,9 +759,9 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id)
}
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
- spin_unlock(&port->lock);
+ spin_unlock_irqrestore(&port->lock, flags);
uart_write_wakeup(port);
- spin_lock(&port->lock);
+ spin_lock_irqsave(&port->lock, flags);
}
if (uart_circ_empty(xmit))
--
1.9.1
next reply other threads:[~2016-02-18 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 17:40 Anand Moon [this message]
2016-02-18 17:48 ` [PATCH] serial: samsung: fix the inconsistency in spinlock Peter Hurley
2016-02-18 19:14 ` Anand Moon
2016-02-18 20:03 ` Peter Hurley
2016-02-19 6:09 ` Krzysztof Kozlowski
2016-02-19 6:51 ` Anand Moon
2016-02-19 7:44 ` Krzysztof Kozlowski
2016-02-19 8:23 ` Anand Moon
2016-02-19 8:27 ` Krzysztof Kozlowski
2016-02-19 8:34 ` Anand Moon
2016-02-21 1:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455817202-3005-1-git-send-email-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).