* [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios
@ 2016-04-29 11:40 Geert Uytterhoeven
2016-04-29 13:11 ` Richard Genoud
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-04-29 11:40 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Peter Hurley, Richard Genoud, Arnd Bergmann, linux-serial,
linux-kernel, Geert Uytterhoeven
The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
It doesn't make much sense to emulate GPIOs using other GPIOs, hence
drop support for that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
---
v2:
- Add Reviewed-by,
- Drop forgotten UART_GPIO_OUT[12] enum values.
---
drivers/tty/serial/serial_mctrl_gpio.c | 2 --
drivers/tty/serial/serial_mctrl_gpio.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
index 02147361eaa94747..821ffa637eb630cb 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -43,8 +43,6 @@ static const struct {
{ "rng", TIOCM_RNG, false, },
{ "rts", TIOCM_RTS, true, },
{ "dtr", TIOCM_DTR, true, },
- { "out1", TIOCM_OUT1, true, },
- { "out2", TIOCM_OUT2, true, },
};
void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
index bcfad5d1db61decf..332a33ab0647cbe3 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.h
+++ b/drivers/tty/serial/serial_mctrl_gpio.h
@@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
UART_GPIO_RI = UART_GPIO_RNG,
UART_GPIO_RTS,
UART_GPIO_DTR,
- UART_GPIO_OUT1,
- UART_GPIO_OUT2,
UART_GPIO_MAX,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios
2016-04-29 11:40 [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven
@ 2016-04-29 13:11 ` Richard Genoud
2016-04-29 13:21 ` Yegor Yefremov
0 siblings, 1 reply; 3+ messages in thread
From: Richard Genoud @ 2016-04-29 13:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, Peter Hurley, Arnd Bergmann,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
2016-04-29 13:40 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>:
> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
> It doesn't make much sense to emulate GPIOs using other GPIOs, hence
> drop support for that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> v2:
> - Add Reviewed-by,
> - Drop forgotten UART_GPIO_OUT[12] enum values.
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 2 --
> drivers/tty/serial/serial_mctrl_gpio.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 02147361eaa94747..821ffa637eb630cb 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -43,8 +43,6 @@ static const struct {
> { "rng", TIOCM_RNG, false, },
> { "rts", TIOCM_RTS, true, },
> { "dtr", TIOCM_DTR, true, },
> - { "out1", TIOCM_OUT1, true, },
> - { "out2", TIOCM_OUT2, true, },
> };
>
> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
> index bcfad5d1db61decf..332a33ab0647cbe3 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.h
> +++ b/drivers/tty/serial/serial_mctrl_gpio.h
> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
> UART_GPIO_RI = UART_GPIO_RNG,
> UART_GPIO_RTS,
> UART_GPIO_DTR,
> - UART_GPIO_OUT1,
> - UART_GPIO_OUT2,
> UART_GPIO_MAX,
> };
>
> --
> 1.9.1
>
It seems all right now !
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios
2016-04-29 13:11 ` Richard Genoud
@ 2016-04-29 13:21 ` Yegor Yefremov
0 siblings, 0 replies; 3+ messages in thread
From: Yegor Yefremov @ 2016-04-29 13:21 UTC (permalink / raw)
To: Richard Genoud
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby, Peter Hurley,
Arnd Bergmann, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, Apr 29, 2016 at 3:11 PM, Richard Genoud
<richard.genoud@gmail.com> wrote:
> 2016-04-29 13:40 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>:
>> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
>> It doesn't make much sense to emulate GPIOs using other GPIOs, hence
>> drop support for that.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>> v2:
>> - Add Reviewed-by,
>> - Drop forgotten UART_GPIO_OUT[12] enum values.
>> ---
>> drivers/tty/serial/serial_mctrl_gpio.c | 2 --
>> drivers/tty/serial/serial_mctrl_gpio.h | 2 --
>> 2 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 02147361eaa94747..821ffa637eb630cb 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -43,8 +43,6 @@ static const struct {
>> { "rng", TIOCM_RNG, false, },
>> { "rts", TIOCM_RTS, true, },
>> { "dtr", TIOCM_DTR, true, },
>> - { "out1", TIOCM_OUT1, true, },
>> - { "out2", TIOCM_OUT2, true, },
>> };
>>
>> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
>> index bcfad5d1db61decf..332a33ab0647cbe3 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.h
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.h
>> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
>> UART_GPIO_RI = UART_GPIO_RNG,
>> UART_GPIO_RTS,
>> UART_GPIO_DTR,
>> - UART_GPIO_OUT1,
>> - UART_GPIO_OUT2,
>> UART_GPIO_MAX,
>> };
>>
>> --
>> 1.9.1
>>
> It seems all right now !
>
>
> Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-29 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29 11:40 [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven
2016-04-29 13:11 ` Richard Genoud
2016-04-29 13:21 ` Yegor Yefremov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).