From: Pramod Gurav <pramod.gurav@linaro.org>
To: gregkh@linuxfoundation.org, jslaby@suse.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Pramod Gurav <pramod.gurav@linaro.org>
Subject: [PATCH] serial_core: Change UART PM state to OFF on failure
Date: Fri, 6 May 2016 15:16:23 +0530 [thread overview]
Message-ID: <1462527983-32108-1-git-send-email-pramod.gurav@linaro.org> (raw)
uart_change_pm is used to turn on the UART controller resources and
change UART's PM status. On failure to allocate pages the controller
be left in ON state. This will change the state to OFF on failure.
Signed-off-by: Pramod Gurav <pramod.gurav@linaro.org>
---
drivers/tty/serial/serial_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 62fe368..58af2e9 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -156,9 +156,10 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
if (!state->xmit.buf) {
/* This is protected by the per port mutex */
page = get_zeroed_page(GFP_KERNEL);
- if (!page)
+ if (!page) {
+ uart_change_pm(state, UART_PM_STATE_OFF);
return -ENOMEM;
-
+ }
state->xmit.buf = (unsigned char *) page;
uart_circ_clear(&state->xmit);
}
--
1.8.2.1
next reply other threads:[~2016-05-06 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 9:46 Pramod Gurav [this message]
2016-06-06 12:06 ` [PATCH] serial_core: Change UART PM state to OFF on failure Pramod Gurav
2016-06-08 16:47 ` Peter Hurley
2016-06-10 5:54 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462527983-32108-1-git-send-email-pramod.gurav@linaro.org \
--to=pramod.gurav@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).