linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	Peter Hurley <peter@hurleysoftware.com>,
	linux-serial@vger.kernel.org
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART
Date: Fri, 06 May 2016 16:38:46 +0300	[thread overview]
Message-ID: <1462541926.17131.285.camel@linux.intel.com> (raw)
In-Reply-To: <1462390180-82368-1-git-send-email-andriy.shevchenko@linux.intel.com>

+Cc: Heikki

On Wed, 2016-05-04 at 22:29 +0300, Andy Shevchenko wrote:
> There are two patches, first of which is an urgent fix to prevent a
> regression
> when UART driver can't acquire DMA channel due to DMA engine which
> doesn't
> support DMA_CYCLIC.

Have to add the following.

The commit ec5a11a91eec ("serial: 8250: Validate dmaengine rx chan meets
requirements") brought a check for DMA capabilities and UART will not
acquire a DMA channel if DMA engine doesn't support both DMA_CYCLIC
_and_ DMA_SLAVE. The first patch in the series changes the logic from
_and_ to _or_.

> 
> Andy Shevchenko (2):
>   dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC
>   dmaengine: rename cmd_pause to cmd_suspend
> 
>  drivers/dma/dmaengine.c               | 8 ++++----
>  drivers/tty/serial/8250/8250_dma.c    | 2 +-
>  include/linux/dmaengine.h             | 4 ++--
>  sound/soc/soc-generic-dmaengine-pcm.c | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      parent reply	other threads:[~2016-05-06 13:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 19:29 [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART Andy Shevchenko
2016-05-04 19:29 ` [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Andy Shevchenko
2016-05-10 15:56   ` Vinod Koul
2016-05-10 16:01     ` Andy Shevchenko
2016-05-10 16:13       ` Vinod Koul
2016-05-04 19:29 ` [PATCH v1 2/2] dmaengine: rename cmd_pause to cmd_suspend Andy Shevchenko
2016-05-10 15:59   ` Vinod Koul
2016-05-10 16:00     ` Andy Shevchenko
2016-05-10 16:11       ` Vinod Koul
2016-05-06 13:38 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462541926.17131.285.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).