From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 3/7] tty: cyclades+mxser, do not initialize to zero
Date: Mon, 9 May 2016 09:11:55 +0200 [thread overview]
Message-ID: <1462777919-10367-3-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1462777919-10367-1-git-send-email-jslaby@suse.cz>
Do not initialize members of initialized structures to zero. They are
zeroed automatically.
Part of hub6 cleanup series.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/tty/cyclades.c | 1 -
drivers/tty/mxser.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 2943d6ff54df..7251430bf149 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -2288,7 +2288,6 @@ static int cy_get_serial_info(struct cyclades_port *info,
.closing_wait = info->port.closing_wait,
.baud_base = info->baud,
.custom_divisor = info->custom_divisor,
- .hub6 = 0, /*!!! */
};
return copy_to_user(retinfo, &tmp, sizeof(*retinfo)) ? -EFAULT : 0;
}
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index ebb8c0034101..2ff280d8045a 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -1219,7 +1219,6 @@ static int mxser_get_serial_info(struct tty_struct *tty,
.close_delay = info->port.close_delay,
.closing_wait = info->port.closing_wait,
.custom_divisor = info->custom_divisor,
- .hub6 = 0
};
if (copy_to_user(retinfo, &tmp, sizeof(*retinfo)))
return -EFAULT;
--
2.8.2
next prev parent reply other threads:[~2016-05-09 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 7:11 [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL Jiri Slaby
2016-05-09 7:11 ` [PATCH 2/7] net: ircomm, " Jiri Slaby
2016-05-10 18:16 ` David Miller
2016-05-09 7:11 ` Jiri Slaby [this message]
2016-05-09 7:11 ` [PATCH 4/7] tty: frv, remove unused serial macros Jiri Slaby
2016-05-09 7:11 ` [PATCH 5/7] tty: stop defining STD_COM_FLAGS in drivers Jiri Slaby
2016-05-09 7:11 ` [PATCH 6/7] tty: 8250, drop unused members from struct old_serial_port Jiri Slaby
2016-05-09 7:11 ` [PATCH 7/7] tty: 8250, kill DEBUG_INTR Jiri Slaby
2016-05-09 7:32 ` [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462777919-10367-3-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).