* [PATCH v2 1/1] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC
@ 2016-05-10 17:43 Andy Shevchenko
2016-05-12 5:45 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2016-05-10 17:43 UTC (permalink / raw)
To: Vinod Koul, linux-kernel, dmaengine, Peter Hurley, linux-serial
Cc: Andy Shevchenko
When check for capabilities recognize slave support by either DMA_SLAVE or
DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
DMA support for engines that doesn't have one of the mentioned bits set.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
In v2:
- fix typo in the commit message
- send patch separately
drivers/dma/dmaengine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 5ff79a0..59eb4fa 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -482,8 +482,8 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
device = chan->device;
/* check if the channel supports slave transactions */
- if ((!test_bit(DMA_SLAVE, device->cap_mask.bits)) ||
- (!test_bit(DMA_CYCLIC, device->cap_mask.bits)))
+ if (!(test_bit(DMA_SLAVE, device->cap_mask.bits) ||
+ test_bit(DMA_CYCLIC, device->cap_mask.bits)))
return -ENXIO;
/*
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC
2016-05-10 17:43 [PATCH v2 1/1] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Andy Shevchenko
@ 2016-05-12 5:45 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-05-12 5:45 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, dmaengine, Peter Hurley, linux-serial
On Tue, May 10, 2016 at 08:43:34PM +0300, Andy Shevchenko wrote:
> When check for capabilities recognize slave support by either DMA_SLAVE or
> DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
> DMA support for engines that doesn't have one of the mentioned bits set.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-12 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 17:43 [PATCH v2 1/1] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Andy Shevchenko
2016-05-12 5:45 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).