From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
z.liuxinliang@hisilicon.com, guohanjun@huawei.com,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Date: Tue, 28 Jun 2016 11:17:15 +0800 [thread overview]
Message-ID: <1467083835-37750-3-git-send-email-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <1467083835-37750-1-git-send-email-wangkefeng.wang@huawei.com>
Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
that it is not 16550 compatibal.
Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out
and serial_in in ACPI.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/tty/serial/8250/8250_dw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 65f3da7..7571b0f 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -301,8 +301,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
p->iotype = UPIO_MEM32;
p->regshift = 2;
p->serial_in = dw8250_serial_in32;
- /* So far none of there implement the Busy Functionality */
- data->uart_16550_compatible = true;
+ p->serial_out = dw8250_serial_out32;
+
+ /* Hisilicon 8250 dw uart is not 16550 compatible */
+ if (!acpi_dev_found("HISI0031"))
+ data->uart_16550_compatible = true;
}
/* Platforms with iDMA */
@@ -618,6 +621,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
{ "APMC0D08", 0},
{ "AMD0020", 0 },
{ "AMDI0020", 0 },
+ { "HISI0031", 0 },
{ },
};
MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
--
1.7.12.4
next prev parent reply other threads:[~2016-06-28 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 3:17 [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang
2016-06-28 3:17 ` [PATCH 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback Kefeng Wang
2016-06-28 3:17 ` Kefeng Wang [this message]
2016-06-29 8:51 ` [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang
2016-06-29 12:52 ` [PATCH 0/2] serial: 8250_dw: Add " Andy Shevchenko
2016-06-30 1:19 ` liuxinliang
2016-06-30 1:24 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467083835-37750-3-git-send-email-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).