From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com
Cc: linux-acpi@vger.kernel.org, guohanjun@huawei.com,
z.liuxinliang@hisilicon.com, xuwei5@hisilicon.com,
graeme.gregory@linaro.org,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v3 1/3] serial: 8250_dw: make dw8250_set_termios as default set_termios callback
Date: Fri, 15 Jul 2016 19:01:23 +0800 [thread overview]
Message-ID: <1468580485-28567-2-git-send-email-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <1468580485-28567-1-git-send-email-wangkefeng.wang@huawei.com>
We can safely use dw8250_set_termios() as the default set_termios
callback instead of serial8250_do_set_termios(), so do it.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/tty/serial/8250/8250_dw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index e199696..65f3da7 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -301,7 +301,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
p->iotype = UPIO_MEM32;
p->regshift = 2;
p->serial_in = dw8250_serial_in32;
- p->set_termios = dw8250_set_termios;
/* So far none of there implement the Busy Functionality */
data->uart_16550_compatible = true;
}
@@ -309,7 +308,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
/* Platforms with iDMA */
if (platform_get_resource_byname(to_platform_device(p->dev),
IORESOURCE_MEM, "lpss_priv")) {
- p->set_termios = dw8250_set_termios;
data->dma.rx_param = p->dev->parent;
data->dma.tx_param = p->dev->parent;
data->dma.fn = dw8250_idma_filter;
@@ -386,6 +384,7 @@ static int dw8250_probe(struct platform_device *pdev)
p->iotype = UPIO_MEM;
p->serial_in = dw8250_serial_in;
p->serial_out = dw8250_serial_out;
+ p->set_termios = dw8250_set_termios;
p->membase = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
if (!p->membase)
--
1.7.12.4
next prev parent reply other threads:[~2016-07-15 11:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 11:01 [PATCH v3 0/3] Kefeng Wang
2016-07-15 11:01 ` Kefeng Wang [this message]
2016-08-22 11:08 ` [PATCH v3 1/3] serial: 8250_dw: make dw8250_set_termios as default set_termios callback Andy Shevchenko
2016-08-24 8:09 ` Kefeng Wang
2016-07-15 11:01 ` [PATCH v3 2/3] serial: 8250_dw: Use new dev variable in probe Kefeng Wang
2016-08-22 11:13 ` Andy Shevchenko
2016-08-24 8:20 ` Kefeng Wang
2016-08-24 10:00 ` Andy Shevchenko
2016-08-24 12:06 ` Kefeng Wang
2016-07-15 11:01 ` [PATCH v3 3/3] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang
2016-08-08 6:10 ` Kefeng Wang
2016-08-22 11:24 ` Andy Shevchenko
2016-08-22 14:05 ` Heikki Krogerus
2016-08-24 8:22 ` Kefeng Wang
2016-08-09 16:01 ` [PATCH v3 0/3] Andy Shevchenko
2016-08-10 5:36 ` Kefeng Wang
2016-08-19 6:26 ` Kefeng Wang
2016-08-22 11:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468580485-28567-2-git-send-email-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jslaby@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).