linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pascal JEAN <epsilonrt@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: sc16is7xx: fix RTS/CTS implementation and add reading CTS
Date: Wed, 27 Jul 2016 22:58:41 +0200	[thread overview]
Message-ID: <1469653123-21867-1-git-send-email-epsilonrt@gmail.com> (raw)

Hi Greg,

Here are explanations of the two patches:

0001-sc16is7xx-fix-RTS-CTS-implementation.patch:
RTS/CTS handshaking for sc16is7xx driver does not work, no character is sent 
regardless of the state of CTS.

This test was done on a raspberry pi 2:

1- sc16is7xx_set_baud() overwrites the flow control configuration bits in EFR. 
Writing in EFR has been replaced by an update.
2- As noted in the file Documentation/serial/driver, 
get_mctrl() should return an active state for unsupported entries.

0002-sc16is7xx-add-reading-CTS.patch:
This patch adds the possibility to read the actual status of the CTS input when
 RTS/CTS handshaking is not activated.

After those changes everything works.

Thank you for your hard work.
Have a nice day.
Pascal

             reply	other threads:[~2016-07-27 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 20:58 Pascal JEAN [this message]
2016-07-27 20:58 ` [PATCH 1/2] sc16is7xx: fix RTS/CTS implementation Pascal JEAN
2016-07-27 21:28   ` Greg KH
2016-07-28  6:56     ` Pascal JEAN
2016-07-28  7:07     ` [PATCH 2/2] sc16is7xx: add reading CTS Pascal JEAN
2016-07-28 14:10       ` Greg KH
2016-07-27 20:58 ` Pascal JEAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469653123-21867-1-git-send-email-epsilonrt@gmail.com \
    --to=epsilonrt@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).