From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Peter Hurley <peter@hurleysoftware.com>,
linux-serial@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ismo.puustinen@intel.com,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v10 03/11] dmaengine: dw: override LLP support if asked in platform data
Date: Fri, 12 Aug 2016 19:01:48 +0300 [thread overview]
Message-ID: <1471017716-44893-4-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1471017716-44893-1-git-send-email-andriy.shevchenko@linux.intel.com>
There are at least two known devices, e.g. DMA controller found on ARC AXS101
SDP board, that have LLP register and no multi block transfer support at the
same time.
Override autodetection by user provided data.
Reported-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dw/core.c | 6 +-----
include/linux/platform_data/dma-dw.h | 2 ++
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
index 80e7421..da18b18 100644
--- a/drivers/dma/dw/core.c
+++ b/drivers/dma/dw/core.c
@@ -1571,11 +1571,7 @@ int dw_dma_probe(struct dw_dma_chip *chip)
(dwc_params >> DWC_PARAMS_MBLK_EN & 0x1) == 0;
} else {
dwc->block_size = pdata->block_size;
-
- /* Check if channel supports multi block transfer */
- channel_writel(dwc, LLP, DWC_LLP_LOC(0xffffffff));
- dwc->nollp = DWC_LLP_LOC(channel_readl(dwc, LLP)) == 0;
- channel_writel(dwc, LLP, 0);
+ dwc->nollp = pdata->is_nollp;
}
}
diff --git a/include/linux/platform_data/dma-dw.h b/include/linux/platform_data/dma-dw.h
index 4636c93..5f0e11e 100644
--- a/include/linux/platform_data/dma-dw.h
+++ b/include/linux/platform_data/dma-dw.h
@@ -40,6 +40,7 @@ struct dw_dma_slave {
* @is_private: The device channels should be marked as private and not for
* by the general purpose DMA channel allocator.
* @is_memcpy: The device channels do support memory-to-memory transfers.
+ * @is_nollp: The device channels does not support multi block transfers.
* @chan_allocation_order: Allocate channels starting from 0 or 7
* @chan_priority: Set channel priority increasing from 0 to 7 or 7 to 0.
* @block_size: Maximum block size supported by the controller
@@ -51,6 +52,7 @@ struct dw_dma_platform_data {
unsigned int nr_channels;
bool is_private;
bool is_memcpy;
+ bool is_nollp;
#define CHAN_ALLOCATION_ASCENDING 0 /* zero to seven */
#define CHAN_ALLOCATION_DESCENDING 1 /* seven to zero */
unsigned char chan_allocation_order;
--
2.8.1
next prev parent reply other threads:[~2016-08-12 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 16:01 [PATCH v10 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 02/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-08-12 16:01 ` Andy Shevchenko [this message]
2016-08-16 13:21 ` [PATCH v10 03/11] dmaengine: dw: override LLP support if asked in platform data Eugeniy Paltsev
2016-08-12 16:01 ` [PATCH v10 04/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-08-15 9:04 ` Bryan O'Donoghue
2016-08-15 9:35 ` Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471017716-44893-4-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pure.logic@nexus-software.ie \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).