From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Peter Hurley <peter@hurleysoftware.com>,
linux-serial@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ismo.puustinen@intel.com,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v10 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes
Date: Fri, 12 Aug 2016 19:01:52 +0300 [thread overview]
Message-ID: <1471017716-44893-8-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1471017716-44893-1-git-send-email-andriy.shevchenko@linux.intel.com>
Intel Quark has 16550A compatible UART with autoflow feature enabled. It has
only 16 bytes of FIFO. Currently serial8250_do_set_termios() prevents to enable
autoflow since the minimum requirement of 32 bytes of FIFO size.
Drop a FIFO size limitation to allow autoflow control be enabled on such UARTs.
While here, comment out UART_CAP_AFE for PORT_AR7 since it wasn't working and
it will be not a good idea to use it in conjunction with trigger level of 1
byte.
Suggested-by: Peter Hurley <peter@hurleysoftware.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_port.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index bdfa659..9bad1c5 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -178,7 +178,7 @@ static const struct serial8250_config uart_config[] = {
.fifo_size = 16,
.tx_loadsz = 16,
.fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_00,
- .flags = UART_CAP_FIFO | UART_CAP_AFE,
+ .flags = UART_CAP_FIFO /* | UART_CAP_AFE */,
},
[PORT_U6_16550A] = {
.name = "U6_16550A",
@@ -2546,12 +2546,9 @@ serial8250_do_set_termios(struct uart_port *port, struct ktermios *termios,
/*
* MCR-based auto flow control. When AFE is enabled, RTS will be
* deasserted when the receive FIFO contains more characters than
- * the trigger, or the MCR RTS bit is cleared. In the case where
- * the remote UART is not using CTS auto flow control, we must
- * have sufficient FIFO entries for the latency of the remote
- * UART to respond. IOW, at least 32 bytes of FIFO.
+ * the trigger, or the MCR RTS bit is cleared.
*/
- if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) {
+ if (up->capabilities & UART_CAP_AFE) {
up->mcr &= ~UART_MCR_AFE;
if (termios->c_cflag & CRTSCTS)
up->mcr |= UART_MCR_AFE;
--
2.8.1
next prev parent reply other threads:[~2016-08-12 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 16:01 [PATCH v10 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 02/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 03/11] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-08-16 13:21 ` Eugeniy Paltsev
2016-08-12 16:01 ` [PATCH v10 04/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-08-12 16:01 ` Andy Shevchenko [this message]
2016-08-12 16:01 ` [PATCH v10 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-08-15 9:04 ` Bryan O'Donoghue
2016-08-15 9:35 ` Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471017716-44893-8-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pure.logic@nexus-software.ie \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).