From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, guohanjun@huawei.com,
z.liuxinliang@hisilicon.com, xuwei5@hisilicon.com,
graeme.gregory@linaro.org
Subject: Re: [PATCH v3 2/3] serial: 8250_dw: Use new dev variable in probe
Date: Wed, 24 Aug 2016 13:00:17 +0300 [thread overview]
Message-ID: <1472032817.4887.253.camel@linux.intel.com> (raw)
In-Reply-To: <c9107ca9-bd35-e80e-135c-1492789e044a@huawei.com>
On Wed, 2016-08-24 at 16:20 +0800, Kefeng Wang wrote:
>
> On 2016/8/22 19:13, Andy Shevchenko wrote:
> >
> > On Fri, 2016-07-15 at 19:01 +0800, Kefeng Wang wrote:
> > >
> > > Use new dev variable instead of pdev->dev and p->dev in probe
> > > function.
> >
> > I'm not sure we need this one. What is wrong with &pdev->dev?
>
> Yes, no error in current code. there are &pdev->dev(A) and p->dev(B),
> some codes use A, others use B, so I want to use an unified one.
>
> If someone don't like this, I will drop it, :)
I want to say that this change doesn't belong to the series in this
case. You may submit it separately later on.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-08-24 10:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 11:01 [PATCH v3 0/3] Kefeng Wang
2016-07-15 11:01 ` [PATCH v3 1/3] serial: 8250_dw: make dw8250_set_termios as default set_termios callback Kefeng Wang
2016-08-22 11:08 ` Andy Shevchenko
2016-08-24 8:09 ` Kefeng Wang
2016-07-15 11:01 ` [PATCH v3 2/3] serial: 8250_dw: Use new dev variable in probe Kefeng Wang
2016-08-22 11:13 ` Andy Shevchenko
2016-08-24 8:20 ` Kefeng Wang
2016-08-24 10:00 ` Andy Shevchenko [this message]
2016-08-24 12:06 ` Kefeng Wang
2016-07-15 11:01 ` [PATCH v3 3/3] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang
2016-08-08 6:10 ` Kefeng Wang
2016-08-22 11:24 ` Andy Shevchenko
2016-08-22 14:05 ` Heikki Krogerus
2016-08-24 8:22 ` Kefeng Wang
2016-08-09 16:01 ` [PATCH v3 0/3] Andy Shevchenko
2016-08-10 5:36 ` Kefeng Wang
2016-08-19 6:26 ` Kefeng Wang
2016-08-22 11:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472032817.4887.253.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jslaby@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).