From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Chen-Yu Tsai <wens@csie.org>, Jiri Slaby <jslaby@suse.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
guohanjun@huawei.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk
Date: Thu, 25 Aug 2016 16:10:12 +0300 [thread overview]
Message-ID: <1472130612.4887.304.camel@linux.intel.com> (raw)
In-Reply-To: <1472129758.4887.303.camel@linux.intel.com>
On Thu, 2016-08-25 at 15:55 +0300, Andy Shevchenko wrote:
> On Wed, 2016-08-24 at 16:33 +0800, Kefeng Wang wrote:
> >
> > It should check the data->pclk, not data->clk when get apb_pclk.
> >
> > Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred
> > probing")
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> pclk is optional on Intel platforms. With your patch we always will
> get
> EPROBE_DEFER that obviously breaks things.
Ah, sorry, it was another culprit.
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> >
> > ---
> > drivers/tty/serial/8250/8250_dw.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > b/drivers/tty/serial/8250/8250_dw.c
> > index e199696..b022f5a 100644
> > --- a/drivers/tty/serial/8250/8250_dw.c
> > +++ b/drivers/tty/serial/8250/8250_dw.c
> > @@ -462,7 +462,7 @@ static int dw8250_probe(struct platform_device
> > *pdev)
> > }
> >
> > data->pclk = devm_clk_get(&pdev->dev, "apb_pclk");
> > - if (IS_ERR(data->clk) && PTR_ERR(data->clk) ==
> > -EPROBE_DEFER)
> > {
> > + if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) ==
> > -EPROBE_DEFER) {
> > err = -EPROBE_DEFER;
> > goto err_clk;
> > }
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-08-25 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 8:33 [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk Kefeng Wang
2016-08-25 12:55 ` Andy Shevchenko
2016-08-25 13:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472130612.4887.304.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).