From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>,
Jiri Slaby <jslaby@suse.com>,
Anton Wuerfel <anton.wuerfel@fau.de>,
Phillip Raffeck <phillip.raffeck@fau.de>,
Peter Hurley <peter@hurleysoftware.com>,
Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tty/serial/8250: unlock on error in serial8250_register_8250_port()
Date: Wed, 31 Aug 2016 19:11:01 +0300 [thread overview]
Message-ID: <1472659861.4887.413.camel@linux.intel.com> (raw)
In-Reply-To: <20160831135758.GA13298@kroah.com>
On Wed, 2016-08-31 at 15:57 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 28, 2016 at 12:15:22PM +0300, Dan Carpenter wrote:
> >
> > We need to unlock before returning here.
> >
> > Fixes: 4ef03d328769 ('tty/serial/8250: use mctrl_gpio helpers')
>
> I ended up reverting this patch, perhaps this is the problem that
> people
> were having with this patch?
Nope, I tried this fix, didn't help.
Mika put the details in his message I mentioned in the patch:
Link: https://lkml.kernel.org/r/20160809130229.GN1729@lahna.fi.intel.com
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-08-31 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 9:15 [patch] tty/serial/8250: unlock on error in serial8250_register_8250_port() Dan Carpenter
2016-08-31 13:57 ` Greg Kroah-Hartman
2016-08-31 16:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472659861.4887.413.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anton.wuerfel@fau.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=peter@hurleysoftware.com \
--cc=phillip.raffeck@fau.de \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=yamada.masahiro@socionext.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).