linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huacai Chen <chenhc@lemote.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org,
	Matthew Leach <matthew.leach@codethink.co.uk>,
	Huacai Chen <chenhc@lemote.com>,
	stable@vger.kernel.org, Ce Sun <sunc@lemote.com>
Subject: [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"
Date: Mon, 14 Nov 2016 10:53:41 +0800	[thread overview]
Message-ID: <1479092021-14885-1-git-send-email-chenhc@lemote.com> (raw)

This reverts commit d03516df837587368fc6e75591f6329c072b9eb5. From
Documentation/serial-console.txt we can know that serial port becomes
the system console only when it appears in the kernel parameters as the
last console device. But commit d03516df837587 adds a CON_CONSDEV flag
to univ8250_console and breaks this convention. After that either we
use "console=tty console=ttyS0" or "console=ttyS0 console=tty", serial
port will always be the system console.

Cc: stable@vger.kernel.org
Signed-off-by: Ce Sun <sunc@lemote.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 240a361..e8819aa 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -675,7 +675,7 @@ static struct console univ8250_console = {
 	.device		= uart_console_device,
 	.setup		= univ8250_console_setup,
 	.match		= univ8250_console_match,
-	.flags		= CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV,
+	.flags		= CON_PRINTBUFFER | CON_ANYTIME,
 	.index		= -1,
 	.data		= &serial8250_reg,
 };
-- 
2.7.0

             reply	other threads:[~2016-11-14  2:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14  2:53 Huacai Chen [this message]
2016-11-14 11:49 ` [PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags" Greg Kroah-Hartman
2017-01-17  7:34   ` 陈华才
2017-01-17  7:54     ` Greg Kroah-Hartman
2017-01-17  8:01       ` 陈华才
  -- strict thread matches above, loose matches on Subject: below --
2016-12-11  2:05 Herbert Xu
2016-12-11  7:12 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479092021-14885-1-git-send-email-chenhc@lemote.com \
    --to=chenhc@lemote.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=matthew.leach@codethink.co.uk \
    --cc=stable@vger.kernel.org \
    --cc=sunc@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).