From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Phil Elwell <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>,
Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Peter Hurley
<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
Yegor Yefremov
<yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] serial: 8250: Fix THRE flag usage for CAP_MINI
Date: Tue, 27 Jun 2017 12:15:36 +0300 [thread overview]
Message-ID: <1498554936.22624.180.camel@linux.intel.com> (raw)
In-Reply-To: <bf050731-6b05-9e35-8b50-ea9115b4197f-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
On Mon, 2017-06-26 at 16:15 +0100, Phil Elwell wrote:
> > But this looks like a bug / quirk than a capability?
> >
> > It would be better to name this define more self-explaining.
> >
> > Btw can't see the definition of UART_CAP_MINI?
>
> The capability was added in d087e7a991f1f61ee2c07db1be7c5cc2aa373f5d,
> which
> is in linux-next. Given that the "capability" already exists and the
> quirk
> is likely to be unique to BCM2835 MINI UART, I don't think we should
> create
> a new quirk.
>
> Besides, the "HFIFO" capability looks a lot like quirk to me.
To me either, which raises a question "Should it be fixed accordingly?"
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
next prev parent reply other threads:[~2017-06-27 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 13:59 [PATCH] serial: 8250: Fix THRE flag usage for CAP_MINI Phil Elwell
[not found] ` <1498485581-72097-1-git-send-email-phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-26 15:05 ` Stefan Wahren
[not found] ` <627a530c-d78c-5338-5ddf-0b3f6a09c37e-eS4NqCHxEME@public.gmane.org>
2017-06-26 15:15 ` Phil Elwell
[not found] ` <bf050731-6b05-9e35-8b50-ea9115b4197f-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-27 9:15 ` Andy Shevchenko [this message]
[not found] ` <1498554936.22624.180.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-27 10:30 ` Phil Elwell
[not found] ` <2669bcda-e1f5-ecb1-a986-99947658bac7-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-27 17:52 ` Andy Shevchenko
[not found] ` <1498585950.22624.210.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-27 21:00 ` Phil Elwell
[not found] ` <aeee2737-623c-c45b-bb18-4ff488684d0c-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-28 7:48 ` Andy Shevchenko
[not found] ` <1498636112.22624.212.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-28 8:09 ` Phil Elwell
[not found] ` <9d796427-3a02-53a6-5426-633bbf6f9a85-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-28 8:18 ` Andy Shevchenko
2017-06-27 9:18 ` Andy Shevchenko
[not found] ` <1498555113.22624.182.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-27 9:24 ` Phil Elwell
2017-06-27 22:36 ` Eric Anholt
-- strict thread matches above, loose matches on Subject: below --
2017-06-28 8:42 Phil Elwell
[not found] ` <1498639379-143432-1-git-send-email-phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-28 8:54 ` Stefan Wahren
[not found] ` <af5786eb-786b-5a50-6b4d-f67b8daf1c8a-eS4NqCHxEME@public.gmane.org>
2017-06-28 9:17 ` Phil Elwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498554936.22624.180.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
--cc=phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
--cc=yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox