linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeffy Chen <jeffy.chen@rock-chips.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, briannorris@chromium.org,
	dianders@chromium.org, peter@hurleysoftware.com,
	Jeffy Chen <jeffy.chen@rock-chips.com>,
	Jiri Slaby <jslaby@suse.com>, Vineet Gupta <vgupta@synopsys.com>,
	linux-serial@vger.kernel.org, linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/5] serial: arc: Remove __init marking from early write
Date: Tue, 18 Jul 2017 14:02:54 +0800	[thread overview]
Message-ID: <1500357778-23169-2-git-send-email-jeffy.chen@rock-chips.com> (raw)
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>

The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.

So remove the __init marking to avoid invalid memory access.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/tty/serial/arc_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 5ac06fc..77fe306 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -549,8 +549,8 @@ static struct console arc_console = {
 	.data	= &arc_uart_driver
 };
 
-static __init void arc_early_serial_write(struct console *con, const char *s,
-					  unsigned int n)
+static void arc_early_serial_write(struct console *con, const char *s,
+				   unsigned int n)
 {
 	struct earlycon_device *dev = con->data;
 
-- 
2.1.4

  reply	other threads:[~2017-07-18  6:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  6:02 [PATCH 0/5] earlycon hang under some conditions Jeffy Chen
2017-07-18  6:02 ` Jeffy Chen [this message]
2017-07-18  6:02 ` [PATCH 2/5] serial: omap: Remove __init marking from early write Jeffy Chen
2017-07-18  6:02 ` [PATCH 3/5] serial: xuartps: " Jeffy Chen
2017-07-18  6:02 ` [PATCH 4/5] serial: 8250_ingenic: " Jeffy Chen
2017-07-18  6:02 ` [PATCH 5/5] serial: 8250_early: " Jeffy Chen
2017-07-18 17:51 ` [PATCH 0/5] earlycon hang under some conditions Brian Norris
2017-07-18 21:17   ` Doug Anderson
2017-07-24 23:50 ` Doug Anderson
2017-07-30 14:31 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500357778-23169-2-git-send-email-jeffy.chen@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=briannorris@chromium.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=peter@hurleysoftware.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).