From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: gregkh@linuxfoundation.org, jirislaby@gmail.com, jslaby@suse.com,
gpiccoli@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH 3/9] tty: synclinkmp: constify pci_device_id.
Date: Sun, 23 Jul 2017 15:31:03 +0530 [thread overview]
Message-ID: <1500804069-11043-4-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500804069-11043-1-git-send-email-arvind.yadav.cs@gmail.com>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
44660 432 104 45196 b08c drivers/tty/synclinkmp.o
File size After adding 'const':
text data bss dec hex filename
44756 336 104 45196 b08c drivers/tty/synclinkmp.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/synclinkmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/synclinkmp.c b/drivers/tty/synclinkmp.c
index 9b4fb02..4fed9e7 100644
--- a/drivers/tty/synclinkmp.c
+++ b/drivers/tty/synclinkmp.c
@@ -479,7 +479,7 @@ static char *driver_version = "$Revision: 4.38 $";
static int synclinkmp_init_one(struct pci_dev *dev,const struct pci_device_id *ent);
static void synclinkmp_remove_one(struct pci_dev *dev);
-static struct pci_device_id synclinkmp_pci_tbl[] = {
+static const struct pci_device_id synclinkmp_pci_tbl[] = {
{ PCI_VENDOR_ID_MICROGATE, PCI_DEVICE_ID_MICROGATE_SCA, PCI_ANY_ID, PCI_ANY_ID, },
{ 0, }, /* terminate list */
};
--
2.7.4
next prev parent reply other threads:[~2017-07-23 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
2017-07-23 10:01 ` [PATCH 1/9] tty: mxser: constify pci_device_id Arvind Yadav
2017-07-23 10:01 ` [PATCH 2/9] tty: isicom: " Arvind Yadav
2017-07-23 10:01 ` Arvind Yadav [this message]
2017-07-23 10:01 ` [PATCH 4/9] tty: synclink: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 5/9] tty: moxa: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 6/9] tty: serial: pci: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 7/9] tty: serial: exar: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 8/9] tty: serial: jsm: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 9/9] tty: synclink_gt: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500804069-11043-4-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).