* [PATCH 1/9] tty: mxser: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 2/9] tty: isicom: " Arvind Yadav
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
20253 1184 19904 41341 a17d drivers/tty/mxser.o
File size After adding 'const':
text data bss dec hex filename
21117 300 19904 41341 a17d drivers/tty/mxser.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/mxser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 8bd6fb6..1c0c955 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -145,7 +145,7 @@ static const struct mxser_cardinfo mxser_cards[] = {
/* driver_data correspond to the lines in the structure above
see also ISA probe function before you change something */
-static struct pci_device_id mxser_pcibrds[] = {
+static const struct pci_device_id mxser_pcibrds[] = {
{ PCI_VDEVICE(MOXA, PCI_DEVICE_ID_MOXA_C168), .driver_data = 3 },
{ PCI_VDEVICE(MOXA, PCI_DEVICE_ID_MOXA_C104), .driver_data = 4 },
{ PCI_VDEVICE(MOXA, PCI_DEVICE_ID_MOXA_CP132), .driver_data = 8 },
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/9] tty: isicom: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
2017-07-23 10:01 ` [PATCH 1/9] tty: mxser: constify pci_device_id Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 3/9] tty: synclinkmp: " Arvind Yadav
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
12176 1520 25864 39560 9a88 drivers/tty/isicom.o
File size After adding 'const':
text data bss dec hex filename
12528 1168 25864 39560 9a88 drivers/tty/isicom.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/isicom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
index b70187b..61ecdd6 100644
--- a/drivers/tty/isicom.c
+++ b/drivers/tty/isicom.c
@@ -150,7 +150,7 @@
static int isicom_probe(struct pci_dev *, const struct pci_device_id *);
static void isicom_remove(struct pci_dev *);
-static struct pci_device_id isicom_pci_tbl[] = {
+static const struct pci_device_id isicom_pci_tbl[] = {
{ PCI_DEVICE(VENDOR_ID, 0x2028) },
{ PCI_DEVICE(VENDOR_ID, 0x2051) },
{ PCI_DEVICE(VENDOR_ID, 0x2052) },
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/9] tty: synclinkmp: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
2017-07-23 10:01 ` [PATCH 1/9] tty: mxser: constify pci_device_id Arvind Yadav
2017-07-23 10:01 ` [PATCH 2/9] tty: isicom: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 4/9] tty: synclink: " Arvind Yadav
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
44660 432 104 45196 b08c drivers/tty/synclinkmp.o
File size After adding 'const':
text data bss dec hex filename
44756 336 104 45196 b08c drivers/tty/synclinkmp.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/synclinkmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/synclinkmp.c b/drivers/tty/synclinkmp.c
index 9b4fb02..4fed9e7 100644
--- a/drivers/tty/synclinkmp.c
+++ b/drivers/tty/synclinkmp.c
@@ -479,7 +479,7 @@ static char *driver_version = "$Revision: 4.38 $";
static int synclinkmp_init_one(struct pci_dev *dev,const struct pci_device_id *ent);
static void synclinkmp_remove_one(struct pci_dev *dev);
-static struct pci_device_id synclinkmp_pci_tbl[] = {
+static const struct pci_device_id synclinkmp_pci_tbl[] = {
{ PCI_VENDOR_ID_MICROGATE, PCI_DEVICE_ID_MICROGATE_SCA, PCI_ANY_ID, PCI_ANY_ID, },
{ 0, }, /* terminate list */
};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/9] tty: synclink: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (2 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 3/9] tty: synclinkmp: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 5/9] tty: moxa: " Arvind Yadav
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
51755 400 513 52668 cdbc drivers/tty/synclink.o
File size After adding 'const':
text data bss dec hex filename
51883 304 513 52700 cddc drivers/tty/synclink.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/synclink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
index 3fafc5a..3be9811 100644
--- a/drivers/tty/synclink.c
+++ b/drivers/tty/synclink.c
@@ -884,7 +884,7 @@ static int synclink_init_one (struct pci_dev *dev,
const struct pci_device_id *ent);
static void synclink_remove_one (struct pci_dev *dev);
-static struct pci_device_id synclink_pci_tbl[] = {
+static const struct pci_device_id synclink_pci_tbl[] = {
{ PCI_VENDOR_ID_MICROGATE, PCI_DEVICE_ID_MICROGATE_USC, PCI_ANY_ID, PCI_ANY_ID, },
{ PCI_VENDOR_ID_MICROGATE, 0x0210, PCI_ANY_ID, PCI_ANY_ID, },
{ 0, }, /* terminate list */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/9] tty: moxa: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (3 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 4/9] tty: synclink: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 6/9] tty: serial: pci: " Arvind Yadav
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
14201 656 1760 16617 40e9 drivers/tty/moxa.o
File size After adding 'const':
text data bss dec hex filename
14329 528 1760 16617 40e9 drivers/tty/moxa.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/moxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index 3b251f4e..7f3d4cb 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -88,7 +88,7 @@ static char *moxa_brdname[] =
};
#ifdef CONFIG_PCI
-static struct pci_device_id moxa_pcibrds[] = {
+static const struct pci_device_id moxa_pcibrds[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_MOXA, PCI_DEVICE_ID_MOXA_C218),
.driver_data = MOXA_BOARD_C218_PCI },
{ PCI_DEVICE(PCI_VENDOR_ID_MOXA, PCI_DEVICE_ID_MOXA_C320),
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/9] tty: serial: pci: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (4 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 5/9] tty: moxa: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 7/9] tty: serial: exar: " Arvind Yadav
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
12626 18128 0 30754 7822 tty/serial/8250/8250_pci.o
File size After adding 'const':
text data bss dec hex filename
23986 6768 0 30754 7822 tty/serial/8250/8250_pci.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/serial/8250/8250_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 00e51a0..553823c 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3723,7 +3723,7 @@ static int pciserial_resume_one(struct device *dev)
static SIMPLE_DEV_PM_OPS(pciserial_pm_ops, pciserial_suspend_one,
pciserial_resume_one);
-static struct pci_device_id serial_pci_tbl[] = {
+static const struct pci_device_id serial_pci_tbl[] = {
/* Advantech use PCI_DEVICE_ID_ADVANTECH_PCI3620 (0x3620) as 'PCI_SUBVENDOR_ID' */
{ PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
PCI_DEVICE_ID_ADVANTECH_PCI3620, 0x0001, 0, 0,
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/9] tty: serial: exar: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (5 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 6/9] tty: serial: pci: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 8/9] tty: serial: jsm: " Arvind Yadav
2017-07-23 10:01 ` [PATCH 9/9] tty: synclink_gt: " Arvind Yadav
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
4030 1280 0 5310 14be tty/serial/8250/8250_exar.o
File size After adding 'const':
text data bss dec hex filename
4958 352 0 5310 14be tty/serial/8250/8250_exar.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/serial/8250/8250_exar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index b5c98e5..6f031fc 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -601,7 +601,7 @@ static const struct exar8250_board pbn_exar_XR17V8358 = {
(kernel_ulong_t)&bd \
}
-static struct pci_device_id exar_pci_tbl[] = {
+static const struct pci_device_id exar_pci_tbl[] = {
CONNECT_DEVICE(XR17C152, UART_2_232, pbn_connect),
CONNECT_DEVICE(XR17C154, UART_4_232, pbn_connect),
CONNECT_DEVICE(XR17C158, UART_8_232, pbn_connect),
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 8/9] tty: serial: jsm: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (6 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 7/9] tty: serial: exar: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
2017-07-23 10:01 ` [PATCH 9/9] tty: synclink_gt: " Arvind Yadav
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2442 1088 8 3538 dd2 tty/serial/jsm/jsm_driver.o
File size After adding 'const':
text data bss dec hex filename
3082 448 8 3538 dd2 tty/serial/jsm/jsm_driver.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/serial/jsm/jsm_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
index a119f11..102d499 100644
--- a/drivers/tty/serial/jsm/jsm_driver.c
+++ b/drivers/tty/serial/jsm/jsm_driver.c
@@ -304,7 +304,7 @@ static void jsm_remove_one(struct pci_dev *pdev)
kfree(brd);
}
-static struct pci_device_id jsm_pci_tbl[] = {
+static const struct pci_device_id jsm_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2DB9), 0, 0, 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2DB9PRI), 0, 0, 1 },
{ PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2RJ45), 0, 0, 2 },
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 9/9] tty: synclink_gt: constify pci_device_id.
2017-07-23 10:01 [PATCH 0/9] constify tty pci_device_id Arvind Yadav
` (7 preceding siblings ...)
2017-07-23 10:01 ` [PATCH 8/9] tty: serial: jsm: " Arvind Yadav
@ 2017-07-23 10:01 ` Arvind Yadav
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-23 10:01 UTC (permalink / raw)
To: gregkh, jirislaby, jslaby, gpiccoli; +Cc: linux-kernel, linux-serial
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
41180 480 185 41845 a375 drivers/tty/synclink_gt.o
File size After adding 'const':
text data bss dec hex filename
41340 320 185 41845 a375 drivers/tty/synclink_gt.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/tty/synclink_gt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
index 529c6e3..636b8ae 100644
--- a/drivers/tty/synclink_gt.c
+++ b/drivers/tty/synclink_gt.c
@@ -95,7 +95,7 @@ MODULE_LICENSE("GPL");
#define MGSL_MAGIC 0x5401
#define MAX_DEVICES 32
-static struct pci_device_id pci_table[] = {
+static const struct pci_device_id pci_table[] = {
{PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT2_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT4_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread