Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller

Sean Wang
2017-08-03T03:18:11Z

On Wed, 2017-08-02 at 21:02 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote:
> > On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> > > On Thu, 2017-08-03 at 01:05 +0800, sean.wang@mediatek.com wrote:
> > > > From: Sean Wang <sean.wang@mediatek.com>
> > > >
> > > > This patchset introduces the support for MediaTek BTIF controller.
> > > >
> > > > MediaTek BTIF controller is the serial interface similar to UART
> > > > but
> > > > it
> > > > works only as the digital device which is mainly used to
> > > > communicate
> > > > with
> > > > the connectivity module also called CONNSYS inside the SoC which
> > > > could
> > > > be
> > > > mostly found on those MediaTek SoCs with Bluetooth feature.
> > > >
> > > > And the controller is made as being compatible with the 8250
> > > > register
> > > > layout so it tends to be integrated with existing 8250 core driver
> > > > and
> > > > have no requirement for the modem configuration additionally such
> > > > as
> > > > the
> > > > baud rate calculation and assignment.
>
> +Cc: Arnd.
>
> > > Why it requires a separate driver?
> > >
> > > 8250_of is for DT enabled drivers.
> > >
> >
> > Hi, Andy
> >
> > thanks for your information
> >
> > the hardware is not completely identical to 8250 device,
> > it has extra registers belonged to platform control such as internal
> > loopback, dma disable/enable, sleep/wakeup setup and so on, so I
> > create
> > it as a separate driver.
>
> Over all 200+ LOCs I didn't see any of the above except loopback, which
> is one property that can be easily added to 8250_of.c.
>
> Moreover, if you have more code coming I would suggest you to split
> 8250_of to library and driver parts and re-use stuff from there.
>
> Arnd, what is your opinion about new 8250 OF based drivers?
>

Hi, Andy

many thanks for the detailed guidance.
I will turn into reusing 8250 OF stuff in the next version and look
forward to any idea from Arnd how to do with 8250 OF driver to add
specific programming/data for those devices using 8250 OF.

Sean