From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: [PATCH v2 2/2] kgdboc: Change printk to the right fashion Date: Tue, 14 Aug 2018 20:46:01 +0800 Message-ID: <1534250761-824-2-git-send-email-zhe.he@windriver.com> References: <1534250761-824-1-git-send-email-zhe.he@windriver.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1534250761-824-1-git-send-email-zhe.he@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: jason.wessel@windriver.com, daniel.thompson@linaro.org, gregkh@linuxfoundation.org, jslaby@suse.com, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: zhe.he@windriver.com List-Id: linux-serial@vger.kernel.org From: He Zhe pr_* is preferred according to scripts/checkpatch.pl. Cc: stable@vger.kernel.org Signed-off-by: He Zhe --- v2: - Split printk cleanups into a single patch - Add cc to stable@vger.kernel.org drivers/tty/serial/kgdboc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 206f8c2..0003d6c 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt) } if (strlen(opt) >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("kgdboc: config string too long\n"); return -ENOSPC; } strcpy(config, opt); @@ -253,7 +253,7 @@ static int param_set_kgdboc_var(const char *kmessage, int len = strlen(kmessage); if (len >= MAX_CONFIG_LEN) { - printk(KERN_ERR "kgdboc: config string too long\n"); + pr_err("kgdboc: config string too long\n"); return -ENOSPC; } @@ -264,8 +264,7 @@ static int param_set_kgdboc_var(const char *kmessage, } if (kgdb_connected) { - printk(KERN_ERR - "kgdboc: Cannot reconfigure while KGDB is connected.\n"); + pr_err("kgdboc: Cannot reconfigure while KGDB is connected.\n"); return -EBUSY; } -- 2.7.4