From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 01/25] tty: Change return type to void
Date: Tue, 4 Sep 2018 11:44:27 +0900 [thread overview]
Message-ID: <1536029091-4426-2-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com>
Many drivers with tty use the tty_stand_install(). But, there is no
need to handle the error, since it always returns 0. So, change the
return type of tty_standard_install() and tty_port_install() to void
type and remove unnecessary exception handling where we use these
functions.
Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
drivers/tty/tty_io.c | 10 ++++++----
drivers/tty/tty_port.c | 4 ++--
include/linux/tty.h | 4 ++--
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 32bc3e3..b01cec8 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1196,13 +1196,12 @@ void tty_init_termios(struct tty_struct *tty)
}
EXPORT_SYMBOL_GPL(tty_init_termios);
-int tty_standard_install(struct tty_driver *driver, struct tty_struct *tty)
+void tty_standard_install(struct tty_driver *driver, struct tty_struct *tty)
{
tty_init_termios(tty);
tty_driver_kref_get(driver);
tty->count++;
driver->ttys[tty->index] = tty;
- return 0;
}
EXPORT_SYMBOL_GPL(tty_standard_install);
@@ -1221,8 +1220,11 @@ EXPORT_SYMBOL_GPL(tty_standard_install);
static int tty_driver_install_tty(struct tty_driver *driver,
struct tty_struct *tty)
{
- return driver->ops->install ? driver->ops->install(driver, tty) :
- tty_standard_install(driver, tty);
+ if (driver->ops->install)
+ return driver->ops->install(driver, tty);
+
+ tty_standard_install(driver, tty);
+ return 0;
}
/**
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index 25d7368..fd8d40d 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -656,11 +656,11 @@ EXPORT_SYMBOL(tty_port_close);
* to a concrete tty specified by @tty. Use this or tty_port_register_device
* (or both). Call tty_port_link_device as a last resort.
*/
-int tty_port_install(struct tty_port *port, struct tty_driver *driver,
+void tty_port_install(struct tty_port *port, struct tty_driver *driver,
struct tty_struct *tty)
{
tty->port = port;
- return tty_standard_install(driver, tty);
+ tty_standard_install(driver, tty);
}
EXPORT_SYMBOL_GPL(tty_port_install);
diff --git a/include/linux/tty.h b/include/linux/tty.h
index c56e397..63cdac1 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -556,7 +556,7 @@ extern struct tty_struct *tty_init_dev(struct tty_driver *driver, int idx);
extern void tty_release_struct(struct tty_struct *tty, int idx);
extern int tty_release(struct inode *inode, struct file *filp);
extern void tty_init_termios(struct tty_struct *tty);
-extern int tty_standard_install(struct tty_driver *driver,
+extern void tty_standard_install(struct tty_driver *driver,
struct tty_struct *tty);
extern struct mutex tty_mutex;
@@ -688,7 +688,7 @@ extern int tty_port_close_start(struct tty_port *port,
extern void tty_port_close_end(struct tty_port *port, struct tty_struct *tty);
extern void tty_port_close(struct tty_port *port,
struct tty_struct *tty, struct file *filp);
-extern int tty_port_install(struct tty_port *port, struct tty_driver *driver,
+extern void tty_port_install(struct tty_port *port, struct tty_driver *driver,
struct tty_struct *tty);
extern int tty_port_open(struct tty_port *port,
struct tty_struct *tty, struct file *filp);
--
2.7.4
next prev parent reply other threads:[~2018-09-04 2:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 2:44 [PATCH 00/25] Change tty_port(standard)_install's return type Jaejoong Kim
2018-09-04 2:44 ` Jaejoong Kim [this message]
2018-09-04 10:45 ` [PATCH 01/25] tty: Change return type to void Sergei Shtylyov
[not found] ` <CAL6iAaKzDPe7CMGR8VOBZRsJqZuNB1=zek_YVvwcKnjimbox2g@mail.gmail.com>
2018-09-05 5:57 ` Jiri Slaby
2018-09-04 2:44 ` [PATCH 02/25] isdn: i4l: isdn_tty: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 03/25] s390: char: con3215: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 04/25] s390: char: tty3270: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 05/25] tty: hvc: hvc_console: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 06/25] tty: hvc: hvcs: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 07/25] tty: mips_ejtag_fdc: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 08/25] tty: n_gsm: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 09/25] tty: serial: kgdb_nmi: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 10/25] tty: synclink: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 11/25] tty: synclinkmp: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 12/25] tty: vt: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 13/25] usb: xhci: dbc: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 14/25] Bluetooth: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 15/25] um: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 16/25] isdn: capi: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 17/25] misc: pti: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 18/25] mmc: core: sdio_uart: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 19/25] staging: fwserial: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 20/25] staging: gdm724x: gdm_tty: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 21/25] staging: greybus: uart: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 22/25] tty: nozomi: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 23/25] tty: vcc: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 24/25] usb: cdc-acm: " Jaejoong Kim
2018-09-04 2:44 ` [PATCH 25/25] usb: usb-serial: " Jaejoong Kim
2018-09-04 4:42 ` [PATCH 00/25] Change tty_port(standard)_install's return type Sam Ravnborg
2018-09-12 14:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536029091-4426-2-git-send-email-climbbb.kim@gmail.com \
--to=climbbb.kim@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).