From: Fabien Lahoudere <fabien.lahoudere@collabora.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs
Date: Wed, 17 Oct 2018 10:20:25 +0200 [thread overview]
Message-ID: <1539764425.3694.1.camel@collabora.com> (raw)
In-Reply-To: <20181015140118.GA16234@kroah.com>
Hi Greg,
On Mon, 2018-10-15 at 16:01 +0200, Greg KH wrote:
> On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote:
> > In order to optimize serial communication on imx53 and imx6, we may
> > need to tweak DMA period and buffer length per period.
>
> Why can you not just automatically determine this information? What is
> userspace going to know that the kernel can not just learn now?
>
> Having tunables is nice, but it is even better to not need them at all.
I agree that it is better to let the kernel do the configuration.
However in our case we use several serial communication for different device
and one of them need to tweak that configuration to get small data with a better
period. However having this parameter for all serial port implies a bigger number
of interrupts for others too.
>
> thanks,
>
> greg k-h
--
Fabien
next prev parent reply other threads:[~2018-10-17 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 9:25 [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs Fabien Lahoudere
2018-10-15 14:01 ` Greg KH
2018-10-17 8:20 ` Fabien Lahoudere [this message]
2018-11-09 17:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539764425.3694.1.camel@collabora.com \
--to=fabien.lahoudere@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).