From: Oliver Neukum <oneukum@suse.com>
To: "Andreas Färber" <afaerber@suse.de>,
linux-lpwan@lists.infradead.org, linux-serial@vger.kernel.org
Cc: Johan Hovold <johan@kernel.org>, Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH RFC 4/5] usb: cdc-acm: Enable serdev support
Date: Mon, 07 Jan 2019 14:48:26 +0100 [thread overview]
Message-ID: <1546868906.3037.37.camel@suse.com> (raw)
In-Reply-To: <20190104112131.14451-5-afaerber@suse.de>
On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote:
> Switch from tty_port_register_device() to tty_port_register_device_serdev()
> and from tty_unregister_device() to tty_port_unregister_device().
>
> On removal of a serdev driver sometimes count mismatch warnings were seen:
>
> ttyACM ttyACM0: tty_hangup: tty->count(1) != (#fd's(0) + #kopen's(0))
> ttyACM ttyACM0: tty_port_close_start: tty->count = 1 port count = 0
>
> Note: The serdev drivers appear to probe asynchronously as soon as they
> are registered. Should the USB quirks in probe be moved before registration?
> No noticeable difference for the devices at hand.
That is quite drastic a change.
Johan, how complete in terms of features is serdev?
Are you refering to CLEAR_HALT_CONDITIONS in terms of quirks?
Regards
Oliver
next prev parent reply other threads:[~2019-01-07 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 11:21 [PATCH RFC lora-next 0/5] net: lora: sx130x: USB CDC Picocell Gateway serdev driver via fake DT nodes Andreas Färber
2019-01-04 11:21 ` [PATCH lora-next 1/5] net: lora: sx130x: Factor out SPI specific parts Andreas Färber
2019-01-04 11:21 ` [PATCH lora-next 2/5] net: lora: sx130x: Prepare storing driver-specific data Andreas Färber
2019-01-04 11:21 ` [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver Andreas Färber
2019-01-05 1:32 ` Andreas Färber
2019-01-05 1:49 ` Andreas Färber
2019-01-05 9:18 ` Ben Whitten
2019-01-07 12:11 ` Oliver Neukum
2019-01-04 11:21 ` [PATCH RFC 4/5] usb: cdc-acm: Enable serdev support Andreas Färber
2019-01-07 13:48 ` Oliver Neukum [this message]
2019-01-07 15:02 ` Johan Hovold
2019-01-04 11:21 ` [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm Andreas Färber
2019-01-04 17:07 ` Rob Herring
2019-01-04 23:43 ` Andreas Färber
2019-01-07 15:28 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546868906.3037.37.camel@suse.com \
--to=oneukum@suse.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lpwan@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).