From: Jiri Slaby <jirislaby@kernel.org>
To: Petr Mladek <pmladek@suse.com>, John Ogness <john.ogness@linutronix.de>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] serial: 8250: drop lockdep annotation from serial8250_clear_IER()
Date: Mon, 14 Aug 2023 12:21:23 +0200 [thread overview]
Message-ID: <154dfc10-76fa-b054-54a8-faa22ad52158@kernel.org> (raw)
In-Reply-To: <ZNn7KHY3iMRarqAZ@alley>
On 14. 08. 23, 12:00, Petr Mladek wrote:
> I personally vote to keep it as is unless people see this warning
> on daily basis. After all, the lockdep splat is correct. The serial
> console might not work correctly in panic() when there is the race.
Sorry, but no, the warning is not correct at all. The code path
deliberately does NOT take the lock and calls a function which is
currently annotated that the lock is _always_ taken. Therefore, the
warning is clearly a false positive and I see no reason in keeping it.
Hopefully this is fixed as John described earlier. Until then, I see no
point bothering people with false alarms.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-08-14 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 6:43 [PATCH] serial: 8250: drop lockdep annotation from serial8250_clear_IER() Jiri Slaby (SUSE)
2023-08-14 6:15 ` John Ogness
2023-08-14 6:28 ` Jiri Slaby
2023-08-14 8:15 ` John Ogness
2023-08-14 10:00 ` Petr Mladek
2023-08-14 10:21 ` Jiri Slaby [this message]
2023-08-15 9:27 ` Petr Mladek
2023-08-15 10:10 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154dfc10-76fa-b054-54a8-faa22ad52158@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).