From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Yuan Yao <yao.yuan@freescale.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>
Subject: Re: [PATCH v3 2/2] serial: fsl_lpuart: add DMA support
Date: Wed, 15 Jan 2014 12:17:07 +0100 [thread overview]
Message-ID: <15900408.Osb5heuoGi@wuerfel> (raw)
In-Reply-To: <20140115110537.GA25824@e106331-lin.cambridge.arm.com>
On Wednesday 15 January 2014 11:05:37 Mark Rutland wrote:
> On Wed, Jan 15, 2014 at 05:21:05AM +0000, Yuan Yao wrote:
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
> > @@ -4,11 +4,24 @@ Required properties:
> > - compatible : Should be "fsl,<soc>-lpuart"
> > - reg : Address and length of the register set for the device
> > - interrupts : Should contain uart interrupt
> > +- clocks : from common clock binding: handle to uart clock
> > +- clock-names : from common clock binding: Shall be "ipg"
>
> Why are these now requried if they weren't previously? That breaks old
> dts. I can't see any new code touching clocks. Was this an old but
> undocumented requirement?
It was previously required but not documented. I asked Yuan Yao to
add the text to the binding along with the new "dmas" addition.
It would have been cleaner to do this as a separate patch, but at
the very least it should be mentioned in the changelog.
Arnd
next prev parent reply other threads:[~2014-01-15 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 5:21 [PATCH v3 1/2] ARM: dts: vf610: lpuart: Add eDMA support Yuan Yao
2014-01-15 5:21 ` [PATCH v3 2/2] serial: fsl_lpuart: add DMA support Yuan Yao
2014-01-15 9:25 ` Arnd Bergmann
2014-01-16 6:02 ` Yao Yuan
2014-01-16 8:19 ` Yao Yuan
2014-01-16 10:47 ` Arnd Bergmann
2014-01-15 11:05 ` Mark Rutland
2014-01-15 11:17 ` Arnd Bergmann [this message]
2014-01-15 13:50 ` Mark Rutland
2014-01-16 6:54 ` Yao Yuan
2014-01-22 3:41 ` Yao Yuan
-- strict thread matches above, loose matches on Subject: below --
2014-01-15 5:24 [PATCH v3 0/2] " Yuan Yao
2014-01-15 5:24 ` [PATCH v3 2/2] " Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15900408.Osb5heuoGi@wuerfel \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=shawn.guo@linaro.org \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).