* [PATCH] tty: serial: qcom_geni_serial: To correct logic for QUP HW version
@ 2020-07-24 6:14 Paras Sharma
2020-07-24 7:13 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Paras Sharma @ 2020-07-24 6:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, linux-arm-msm, linux-serial, linux-kernel, akashast,
Paras Sharma
To correct the logic to detect whether the QUP HW version is greater
than 2.5.
Signed-off-by: Paras Sharma <parashar@codeaurora.org>
---
drivers/tty/serial/qcom_geni_serial.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 1ed3d35..5b0efb49 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -954,7 +954,8 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
sampling_rate = UART_OVERSAMPLING;
/* Sampling rate is halved for IP versions >= 2.5 */
ver = geni_se_get_qup_hw_version(&port->se);
- if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+ if ((GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
+ || GENI_SE_VERSION_MAJOR(ver) >= 3)
sampling_rate /= 2;
clk_rate = get_clk_div_rate(baud, sampling_rate, &clk_div);
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: serial: qcom_geni_serial: To correct logic for QUP HW version
2020-07-24 6:14 [PATCH] tty: serial: qcom_geni_serial: To correct logic for QUP HW version Paras Sharma
@ 2020-07-24 7:13 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-24 7:13 UTC (permalink / raw)
To: Paras Sharma
Cc: Jiri Slaby, linux-arm-msm, linux-serial, linux-kernel, akashast
On Fri, Jul 24, 2020 at 11:44:02AM +0530, Paras Sharma wrote:
> To correct the logic to detect whether the QUP HW version is greater
> than 2.5.
The subject line and here does not make any sense. Can you reword this
as what the problem is and why you need to change this?
>
> Signed-off-by: Paras Sharma <parashar@codeaurora.org>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 1ed3d35..5b0efb49 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -954,7 +954,8 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
> sampling_rate = UART_OVERSAMPLING;
> /* Sampling rate is halved for IP versions >= 2.5 */
> ver = geni_se_get_qup_hw_version(&port->se);
> - if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
> + if ((GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5)
> + || GENI_SE_VERSION_MAJOR(ver) >= 3)
Odd coding style :(
Please fix all of the above up and resubmit a v2.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-24 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-24 6:14 [PATCH] tty: serial: qcom_geni_serial: To correct logic for QUP HW version Paras Sharma
2020-07-24 7:13 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).