From: Magnus Damm <damm@opensource.se>
To: linux-serial@vger.kernel.org
Cc: Magnus Damm <damm@opensource.se>,
geert+renesas@glider.be, gregkh@linuxfoundation.org,
linux-renesas-soc@vger.kernel.org,
wsa+renesas@sang-engineering.com, jirislaby@kernel.org
Subject: [PATCH] serial: sh-sci: Remove BREAK/FRAME/PARITY/OVERRUN printouts
Date: Tue, 07 Dec 2021 11:02:20 +0900 [thread overview]
Message-ID: <163884254093.18109.2982470198301927679.sendpatchset@octo> (raw)
From: Magnus Damm <damm+renesas@opensource.se>
Update the SCIF serial driver to remove printouts for break, frame, parity
and overrun errors. This reduces the amount of console printouts generated
by the defconfig kernel on R-Car Gen3 for certain use cases. To retrieve
more information about such errors the user may inspect counters. Also these
errors are fed into the TTY layer for further application specific handling.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Applies to v5.16-rc4
Previous version sent as:
[PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors
drivers/tty/serial/sh-sci.c | 12 ------------
1 file changed, 12 deletions(-)
--- 0001/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2021-12-07 10:37:45.974123374 +0900
@@ -895,11 +895,9 @@ static void sci_receive_chars(struct uar
if (status & SCxSR_FER(port)) {
flag = TTY_FRAME;
port->icount.frame++;
- dev_notice(port->dev, "frame error\n");
} else if (status & SCxSR_PER(port)) {
flag = TTY_PARITY;
port->icount.parity++;
- dev_notice(port->dev, "parity error\n");
} else
flag = TTY_NORMAL;
@@ -939,8 +937,6 @@ static int sci_handle_errors(struct uart
/* overrun error */
if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))
copied++;
-
- dev_notice(port->dev, "overrun error\n");
}
if (status & SCxSR_FER(port)) {
@@ -949,8 +945,6 @@ static int sci_handle_errors(struct uart
if (tty_insert_flip_char(tport, 0, TTY_FRAME))
copied++;
-
- dev_notice(port->dev, "frame error\n");
}
if (status & SCxSR_PER(port)) {
@@ -959,8 +953,6 @@ static int sci_handle_errors(struct uart
if (tty_insert_flip_char(tport, 0, TTY_PARITY))
copied++;
-
- dev_notice(port->dev, "parity error\n");
}
if (copied)
@@ -990,8 +982,6 @@ static int sci_handle_fifo_overrun(struc
tty_insert_flip_char(tport, 0, TTY_OVERRUN);
tty_flip_buffer_push(tport);
-
- dev_dbg(port->dev, "overrun error\n");
copied++;
}
@@ -1013,8 +1003,6 @@ static int sci_handle_breaks(struct uart
/* Notify of BREAK */
if (tty_insert_flip_char(tport, 0, TTY_BREAK))
copied++;
-
- dev_dbg(port->dev, "BREAK detected\n");
}
if (copied)
next reply other threads:[~2021-12-07 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 2:02 Magnus Damm [this message]
2021-12-07 7:52 ` [PATCH] serial: sh-sci: Remove BREAK/FRAME/PARITY/OVERRUN printouts Geert Uytterhoeven
2021-12-07 8:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163884254093.18109.2982470198301927679.sendpatchset@octo \
--to=damm@opensource.se \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox