From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: samsung: Add missing checks for dma_map_single failure
Date: Thu, 23 Mar 2017 12:59:18 +0100 [thread overview]
Message-ID: <1721523.vQEeMhhi8C@amdc3058> (raw)
In-Reply-To: <3019209.fgIhMIWD3x@amdc3058>
On Thursday, March 23, 2017 12:04:02 PM Bartlomiej Zolnierkiewicz wrote:
> On Thursday, March 23, 2017 08:45:22 AM Marek Szyprowski wrote:
> > This patch adds missing checks for dma_map_single() failure and proper error
> > reporting. While touching this part of the code, it also removes unnecessary
> > spinlock calls around dma_map_single() for TX buffer. This finally solves all
> > the issues reported by DMA API debug framework.
> >
> > Reported-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> > Fixes: 2c37eedb74c8 ("serial: samsung: add dma reqest/release functions")
>
> The right commit id is 62c37eedb74c8.
BTW With this fixed you may add:
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
to both patches.
> > CC: stable@vger.kernel.org # v4.10+
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Best regards,
next prev parent reply other threads:[~2017-03-23 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170323074548eucas1p142511884e12d6211bebd9cbabde2f9c9@eucas1p1.samsung.com>
2017-03-23 7:45 ` [PATCH 1/2] serial: samsung: Use right device for DMA-mapping calls Marek Szyprowski
2017-03-23 7:45 ` [PATCH 2/2] serial: samsung: Add missing checks for dma_map_single failure Marek Szyprowski
2017-03-23 11:04 ` Bartlomiej Zolnierkiewicz
2017-03-23 11:59 ` Bartlomiej Zolnierkiewicz [this message]
2017-03-23 11:02 ` [PATCH 1/2] serial: samsung: Use right device for DMA-mapping calls Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1721523.vQEeMhhi8C@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=stable@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox