From: "Rob Herring (Arm)" <robh@kernel.org>
To: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
Cc: linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
paul.barker.ct@bp.renesas.com, geert@linux-m68k.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, thierry.bultel@linatsea.fr
Subject: Re: [PATCH v9 01/10] dt-bindings: serial: Added secondary clock for RZ/T2H RSCI
Date: Thu, 15 May 2025 10:35:08 -0500 [thread overview]
Message-ID: <174732330847.829507.6367540282698483743.robh@kernel.org> (raw)
In-Reply-To: <20250515141828.43444-2-thierry.bultel.yh@bp.renesas.com>
On Thu, 15 May 2025 16:18:16 +0200, Thierry Bultel wrote:
> At boot, the default clock is the PCLKM core clock (synchronous
> clock, which is enabled by the bootloader).
> For different baudrates, the asynchronous clock input must be used.
> Clock selection is made by an internal register of RCSI.
>
> Also remove the unneeded serial0 alias from the dts example.
>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
> ---
> Changes v8->v9:
> - typo in description
> - named clocks 'operational' and 'bus', and added optional 'sck' clock
> - uses value of 2nd core clock in example to break the dependency on cpg patch
> ---
> .../bindings/serial/renesas,rsci.yaml | 21 +++++++++++--------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/serial/renesas,rsci.example.dts:25:18: fatal error: dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h: No such file or directory
25 | #include <dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/serial/renesas,rsci.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250515141828.43444-2-thierry.bultel.yh@bp.renesas.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-05-15 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250515141828.43444-1-thierry.bultel.yh@bp.renesas.com>
2025-05-15 14:18 ` [PATCH v9 01/10] dt-bindings: serial: Added secondary clock for RZ/T2H RSCI Thierry Bultel
2025-05-15 15:35 ` Rob Herring (Arm) [this message]
2025-05-23 9:05 ` Geert Uytterhoeven
2025-05-15 14:18 ` [PATCH v9 06/10] serial: sh-sci: Use private port ID Thierry Bultel
2025-05-21 11:00 ` Wolfram Sang
2025-05-23 9:45 ` Geert Uytterhoeven
2025-05-23 12:21 ` Wolfram Sang
2025-05-23 12:27 ` Thierry Bultel
2025-05-23 13:15 ` Wolfram Sang
2025-05-23 9:46 ` Geert Uytterhoeven
2025-05-23 13:17 ` Wolfram Sang
2025-05-15 14:18 ` [PATCH v9 07/10] serial: sh-sci: Add support for RZ/T2H SCI Thierry Bultel
2025-05-23 9:57 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174732330847.829507.6367540282698483743.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=thierry.bultel@linatsea.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox