Re: [PATCH v2 31/53] mfd: ioc3: Add support for IOC4

[Lee Jones <lee@kernel.org>]

--- checkpatch.pl: clean (0 issues) ---

On Tue, 13 Oct 2026, Imre Kaloz wrote:

> IOC4 is IOC3's successor on IP35 Origin 350-class boards. Its serial and
> PS/2 cores reuse IOC3's drivers and its interrupt status splits into two
> banks. The serial ports need IOC4 firmware revision 62 or later and are
> not registered on older firmware.
>
> The serial, interrupt and GPIO register definitions in asm/sn/ioc4.h
> follow include/linux/ioc4.h and drivers/tty/serial/ioc4_serial.c, removed
> by commit f7bc6e42bf12 ("drivers: remove the SGI SN2 IOC4 base support")
> and commit a017ef17cfd8 ("tty/serial: remove the ioc4_serial driver").
>
> Signed-off-by: Imre Kaloz <kaloz@kernel.org>
> ---
>  MAINTAINERS                                   |   1 +
>  arch/mips/include/asm/sn/ioc4.h               | 142 ++++++++
>  drivers/mfd/ioc3.c                            | 323 +++++++++++++++---
>  drivers/tty/serial/8250/8250_ioc3.c           |   5 +-
>  include/linux/platform_data/sgi-ioc3-serial.h |  13 +
>  5 files changed, 438 insertions(+), 46 deletions(-)

Do we really need to bundle all of these changes into this commit?

This is going to be a nightmare to review!

>  create mode 100644 arch/mips/include/asm/sn/ioc4.h
>  create mode 100644 include/linux/platform_data/sgi-ioc3-serial.h

-- 
Lee Jones