Re: [PATCH 7/9] serdev: Introduce new bus for serial attached devices

Pavel Machek
2017-01-10T21:46:17Z

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi!

> +static void serdev_ctrl_release(struct device *dev)
> +{
> + struct serdev_controller *ctrl = to_serdev_controller(dev);
> + ida_simple_remove(&ctrl_ida, ctrl->nr);
> + kfree(ctrl);
> +}

Would it make sense to do something like to_serdev_controller(dev) =
NULL; there?

> +MODULE_AUTHOR("Rob Herring <robh@kernel.org");

Missing >.

Thanks,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]