linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Kukjin Kim' <kgene.kim@samsung.com>,
	'Chander Kashyap' <chander.kashyap@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	t.figa@samsung.com, s.nawrocki@samsung.com, mark.rutland@arm.com,
	thomas.ab@samsung.com,
	'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
	jslaby@suse.cz
Subject: RE: [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined
Date: Tue, 18 Jun 2013 19:31:06 +0900	[thread overview]
Message-ID: <1c0e01ce6c0e$f0baf7d0$d230e770$%kim@samsung.com> (raw)
In-Reply-To: 

Kukjin Kim wrote:
> 
> Chander Kashyap wrote:
> >
> > All Exynos4/5 SoCs share a common driver data in the samsung serial
> > driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS
> > instead of SOC specific definition.
> >
> > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> 
> (+ Greg, Jiri)
> 
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> Greg, Jiri, please take this in your tree with my ack if no problem on
> this.
> 
Greg, Jiri, since there are other changes for this in samsung tree so would
be nice if this could be sent to upstream with others via samsung tree. If
you have any concerns, please kindly let me know.

Thanks,
- Kukjin
> 
> > ---
> >  drivers/tty/serial/samsung.c |    4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index 2552c7f..e70d19a 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -1703,9 +1703,7 @@ static struct s3c24xx_serial_drv_data
> > s5pv210_serial_drv_data = {
> >  #define S5PV210_SERIAL_DRV_DATA	(kernel_ulong_t)NULL
> >  #endif
> >
> > -#if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) ||
> \
> > -	defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) ||
> > \
> > -	defined(CONFIG_SOC_EXYNOS5440)
> > +#if defined(CONFIG_ARCH_EXYNOS)
> >  static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
> >  	.info = &(struct s3c24xx_uart_info) {
> >  		.name		= "Samsung Exynos4 UART",
> > --
> > 1.7.9.5


  parent reply	other threads:[~2013-06-18 10:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 11:00 [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-17 11:38   ` Kukjin Kim
2013-06-18  4:24     ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-17 11:45   ` Kukjin Kim
2013-06-18 10:31   ` Kukjin Kim [this message]
2013-06-18 15:19     ` 'Greg Kroah-Hartman'
2013-06-17 11:00 ` [PATCH v3 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-17 11:49   ` Kukjin Kim
2013-06-17 12:27   ` Arnd Bergmann
2013-06-18  4:09     ` Chander Kashyap
2013-06-18 14:01       ` Arnd Bergmann
2013-06-18 14:26         ` Tomasz Figa
2013-06-18 17:13           ` Arnd Bergmann
2013-06-17 11:00 ` [PATCH v3 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-17 11:44   ` Tomasz Figa
2013-06-18  4:21     ` Chander Kashyap
2013-06-18  7:36       ` Tomasz Figa
2013-06-17 11:00 ` [PATCH v3 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-17 11:53   ` Kukjin Kim
2013-06-18  4:11     ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-17 12:21   ` Arnd Bergmann
2013-06-18  4:10     ` Chander Kashyap
2013-06-17 11:45 ` [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Tomasz Figa
2013-06-17 11:56 ` Kukjin Kim
2013-06-18  4:28   ` Chander Kashyap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1c0e01ce6c0e$f0baf7d0$d230e770$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=chander.kashyap@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=s.nawrocki@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).