From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fugang Duan <fugang.duan@nxp.com>,
Sherry Sun <sherry.sun@nxp.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [PATCH] serial: fsl_lpuart: Reset prior to registration
Date: Tue, 13 Sep 2022 10:20:58 +0300 (EEST) [thread overview]
Message-ID: <1d78424-e7e9-9379-3c61-ac268cb9b3c@linux.intel.com> (raw)
In-Reply-To: <72fb646c1b0b11c989850c55f52f9ff343d1b2fa.1662884345.git.lukas@wunner.de>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Sun, 11 Sep 2022, Lukas Wunner wrote:
> Since commit bd5305dcabbc ("tty: serial: fsl_lpuart: do software reset
> for imx7ulp and imx8qxp"), certain i.MX UARTs are reset after they've
> already been registered. Register state may thus be clobbered after
> user space has begun to open and access the UART.
>
> Avoid by performing the reset prior to registration.
>
> Fixes: bd5305dcabbc ("tty: serial: fsl_lpuart: do software reset for imx7ulp and imx8qxp")
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: stable@vger.kernel.org # v5.15+
> Cc: Fugang Duan <fugang.duan@nxp.com>
> Cc: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2022-09-13 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 8:22 [PATCH] serial: fsl_lpuart: Reset prior to registration Lukas Wunner
2022-09-13 7:20 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d78424-e7e9-9379-3c61-ac268cb9b3c@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).