From: Krzysztof Kozlowski <krzk@kernel.org>
To: Praveen Talari <quic_ptalari@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
psodagud@quicinc.com, djaggi@quicinc.com,
quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com,
quic_arandive@quicinc.com, quic_mnaresh@quicinc.com,
quic_shazhuss@quicinc.com, Nikunj Kela <quic_nkela@quicinc.com>
Subject: Re: [PATCH v4 1/8] dt-bindings: serial: describe SA8255p
Date: Mon, 5 May 2025 11:59:39 +0200 [thread overview]
Message-ID: <1de5c0b7-7761-4d0c-bced-7e26150e995f@kernel.org> (raw)
In-Reply-To: <4ebe065e-9686-4e35-bb00-a9e816fb8926@quicinc.com>
On 05/05/2025 08:51, Praveen Talari wrote:
>>>>> + serial@990000 {
>>>>> + compatible = "qcom,sa8255p-geni-uart";
>>>>> + reg = <0x990000 0x4000>;
>>>>> + interrupts = <GIC_SPI 531 IRQ_TYPE_LEVEL_HIGH>;
>>>> Why isn't here wakeup interrupt? Commit msg also does not help me to
>>>> understand why number of interrupts varies.
>>> Currently we are not using wake-irq because it is optional for our current
>>> implementation.
>> Great explanation. I asked why is it optional, answer because it is
>> optional.
> sorry.
>>
>> What does it mean optional? This is part of the SoC, so how given one,
>> fixed SoC can have it routed or not routed in the same time?
>
> the serial driver doesn't enter runtime suspend mode until the port is
> closed.
>
> therefore, there is no need for a wake IRQ when the driver is in an
> active state
You described current Linux driver, so if we change Linux driver or we
try for example FreeBSD, then bindings are different?
Again, explain how SoC can have this interrupt not routed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-05 9:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 17:14 [PATCH v4 0/8] Enable QUPs and Serial on SA8255p Qualcomm platforms Praveen Talari
2025-05-02 17:14 ` [PATCH v4 1/8] dt-bindings: serial: describe SA8255p Praveen Talari
2025-05-04 17:09 ` Krzysztof Kozlowski
2025-05-05 2:30 ` Praveen Talari
2025-05-05 6:31 ` Krzysztof Kozlowski
2025-05-05 6:51 ` Praveen Talari
2025-05-05 9:59 ` Krzysztof Kozlowski [this message]
2025-05-05 13:42 ` Praveen Talari
2025-05-05 16:01 ` Konrad Dybcio
2025-05-06 6:15 ` Krzysztof Kozlowski
2025-05-06 18:05 ` Praveen Talari
2025-05-02 17:14 ` [PATCH v4 2/8] dt-bindings: qcom: geni-se: " Praveen Talari
2025-05-04 17:09 ` Krzysztof Kozlowski
2025-05-02 17:14 ` [PATCH v4 3/8] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms Praveen Talari
2025-05-02 17:14 ` [PATCH v4 4/8] serial: qcom-geni: move resource initialization to separate function Praveen Talari
2025-05-02 17:14 ` [PATCH v4 5/8] serial: qcom-geni: move resource control logic to separate functions Praveen Talari
2025-05-02 17:14 ` [PATCH v4 6/8] serial: qcom-geni: move clock-rate logic to separate function Praveen Talari
2025-05-02 17:14 ` [PATCH v4 7/8] serial: qcom-geni: Enable PM runtime for serial driver Praveen Talari
2025-05-02 17:14 ` [PATCH v4 8/8] serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de5c0b7-7761-4d0c-bced-7e26150e995f@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djaggi@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=psodagud@quicinc.com \
--cc=quic_arandive@quicinc.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_nkela@quicinc.com \
--cc=quic_ptalari@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox