public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>,
	gregkh@linuxfoundation.org, jslaby@suse.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	vigneshr@ti.com, joel@jms.id.au, khoroshilov@ispras.ru,
	arnd@arndb.de, robert.jarzmik@free.fr,
	tthayer@opensource.altera.com
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH v3] serial: 8250_of: Add basic PM runtime support
Date: Mon, 21 Aug 2017 17:50:58 +0530	[thread overview]
Message-ID: <1e3ad33d-882e-d4a0-6295-ac06397b11d2@ti.com> (raw)
In-Reply-To: <20170816205536.19634-1-fcooper@ti.com>

On Thursday 17 August 2017 02:25 AM, Franklin S Cooper Jr wrote:
> 66AK2G UART instances are not apart of the ALWAYS_ON power domain.
> Therefore, pm_runtime calls must be made to properly insure the appropriate
> power domains needed by UART are on. Keep legacy clk api calls since other
> users of this driver may not support PM runtime.

Do we really have users like that? And even if there are, cant they use
PM clock handling support available in drivers/base/power/clock_ops.c ?

The clock enable support itself was added pretty "recently" - about 5
years back with 0bbeb3c3e84b ("of serial port driver - add
clk_get_rate() support"). So I doubt any really legacy platforms relied
on clock support being there. It was added by Murali, I assume for
Keystone devices. Keystone devices can work with runtime PM using the PM
clock support pointed to above.

Perhaps linux-arm-kernel list should be copied on this submission too,
since most users of this driver are likely to be there on that list.

> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>

Thanks,
Sekhar

  reply	other threads:[~2017-08-21 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 20:55 [PATCH v3] serial: 8250_of: Add basic PM runtime support Franklin S Cooper Jr
2017-08-21 12:20 ` Sekhar Nori [this message]
2017-08-21 16:59   ` Franklin S Cooper Jr
2017-08-23  6:34     ` Sekhar Nori
2017-08-23  7:19       ` Franklin S Cooper Jr
2017-08-23  8:15         ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e3ad33d-882e-d4a0-6295-ac06397b11d2@ti.com \
    --to=nsekhar@ti.com \
    --cc=arnd@arndb.de \
    --cc=fcooper@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@jms.id.au \
    --cc=jslaby@suse.com \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=robert.jarzmik@free.fr \
    --cc=tthayer@opensource.altera.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox