From: Russell King <rmk@arm.linux.org.uk>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: axel@hh59.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, tytso@mit.edu
Subject: Re: Linux 2.5.30: [SERIAL] build fails at 8250.c
Date: Sat, 3 Aug 2002 09:05:23 +0100 [thread overview]
Message-ID: <20020803090523.A22424@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200208030020.RAA05695@baldur.yggdrasil.com>; from adam@yggdrasil.com on Fri, Aug 02, 2002 at 05:20:28PM -0700
On Fri, Aug 02, 2002 at 05:20:28PM -0700, Adam J. Richter wrote:
> On Sat, 3 Aug 2002 01:12:10 +0100, Russell King wrote:
> >Ok, here's a fix for the 8250.c build problem (please don't send it
> >to Linus; I've other changes that'll be going via BK and patch to
> >lkml pending):
> >
> >--- orig/drivers/serial/8250.c Fri Aug 2 21:13:31 2002
> >+++ linux/drivers/serial/8250.c Sat Aug 3 00:28:47 2002
> >@@ -31,7 +31,8 @@
> > #include <linux/console.h>
> > #include <linux/sysrq.h>
> > #include <linux/serial_reg.h>
> >-#include <linux/serialP.h>
> >+#include <linux/circ_buf.h>
> >+#include <linux/serial.h>
> > #include <linux/delay.h>
> >
> > #include <asm/io.h>
>
> Your patch still results in a compilation error for me.
> It looks like 8250.c needs <linux/serialP.h> for ALPHA_KLUDGE_MCR:
Your quote above didn't include the patch for 8250.h which was in my
mail directly after 8250.c. Did you specifically miss it for a reason?
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-08-03 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-03 0:20 Linux 2.5.30: [SERIAL] build fails at 8250.c Adam J. Richter
2002-08-03 8:05 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-03 8:42 Adam J. Richter
2002-08-02 22:49 Adam J. Richter
2002-08-02 23:56 ` Russell King
[not found] ` <20020803005626.D16963@flint.arm.linux.org.uk>
2002-08-03 0:12 ` Russell King
2002-08-03 1:05 ` Kai Germaschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020803090523.A22424@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=adam@yggdrasil.com \
--cc=axel@hh59.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox