From: Russell King <rmk@arm.linux.org.uk>
To: Michael Anderson <mjanders@us.ibm.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] linux-2.6.2-rc3 Add icom serial device driver
Date: Sat, 21 Feb 2004 23:02:33 +0000 [thread overview]
Message-ID: <20040221230233.C18248@flint.arm.linux.org.uk> (raw)
In-Reply-To: <OF44D236E7.513A2596-ON86256E38.00773808-86256E38.00777F7E@us.ibm.com>; from mjanders@us.ibm.com on Thu, Feb 12, 2004 at 03:44:35PM -0600
On Thu, Feb 12, 2004 at 03:44:35PM -0600, Michael Anderson wrote:
> Updated icom patch can be found at:
>
> http://www-124.ibm.com/linux/patches/misc/icom-2.6.3-rc2.patch
I was just giving this it's final going over, and I noticed the following
in icom_init():
+ if (ret < 0) {
+ pci_unregister_driver(&icom_pci_driver);
+ uart_unregister_driver(&icom_uart_driver);
+ }
If pci_register_driver() fails in 2.6, you must not call
pci_unregister_driver.
I think there may be issues concerning the firmware in the .h file.
Can you give any information about the licensing policy on it please?
It may need to use the kernels firmware loader (for more info on that
see drivers/base/firmware_class.c)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-02-21 23:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-12 21:44 [PATCH] linux-2.6.2-rc3 Add icom serial device driver Michael Anderson
2004-02-21 23:02 ` Russell King [this message]
2004-03-09 14:43 ` Michael Anderson
-- strict thread matches above, loose matches on Subject: below --
2004-02-06 23:03 Michael Anderson
2004-02-06 20:42 Michael Anderson
2004-02-06 20:12 Michael Anderson
2004-02-06 20:17 ` Greg KH
2004-02-06 21:13 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040221230233.C18248@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-serial@vger.kernel.org \
--cc=mjanders@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).