linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Harald Welte <laforge@gnumonks.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: Fix supprot for AFAVLAB 8port boards in 2.6.x
Date: Fri, 5 Mar 2004 20:38:21 +0000	[thread overview]
Message-ID: <20040305203821.D12413@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040305112404.GJ1105@sunbeam.de.gnumonks.org>; from laforge@gnumonks.org on Fri, Mar 05, 2004 at 12:24:04PM +0100

On Fri, Mar 05, 2004 at 12:24:04PM +0100, Harald Welte wrote:
> I didn't yet use one of my AFAVLAB boards with 2.6.x until now.  The
> upper 4 ports are not detected at all.  I suppose the bug was introduced
> while porting the driver from 2.4.x.

Yep, looks like I missed that subtle "bar = 4" part.  Applied, thanks.

> diff -Nru --exclude-from /sunbeam/home/laforge/scripts/dontdiff linuxppc25bh-040218-test/drivers/serial/8250_pci.c linuxppc25bh-040218-serial/drivers/serial/8250_pci.c
> --- linuxppc25bh-040218-test/drivers/serial/8250_pci.c	2004-02-16 09:44:28.000000000 +0100
> +++ linuxppc25bh-040218-serial/drivers/serial/8250_pci.c	2004-03-05 12:23:02.331325424 +0100
> @@ -141,13 +141,15 @@
>  	      struct serial_struct *req, int idx)
>  {
>  	unsigned int bar, offset = board->first_offset;
>  	
>  	bar = FL_GET_BASE(board->flags);
>  	if (idx < 4)
>  		bar += idx;
> -	else
> +	else {
> +		bar = 4;
>  		offset += (idx - 4) * board->uart_offset;
> +	}
>  
>  	return setup_port(dev, req, bar, offset, board->reg_shift);
>  }
>  

I detect patch editing here, which appears to have broken the patch (it
didn't apply.)  I've manually fixed it so you don't need to worry.

Please ensure that your patches apply and unapply cleanly to the base
kernel before sending, especially if you've edited the patch file.

Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

      parent reply	other threads:[~2004-03-05 20:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-05 11:24 Fix supprot for AFAVLAB 8port boards in 2.6.x Harald Welte
2004-03-05 14:15 ` Roman Kurakin
2004-03-05 14:13   ` Harald Welte
2004-03-05 20:38 ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040305203821.D12413@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=laforge@gnumonks.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).